Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add managed instances swagger to 2018-06-01-preview #6441

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Add managed instances swagger to 2018-06-01-preview #6441

merged 3 commits into from
Jun 25, 2019

Conversation

johnpaulkee
Copy link
Contributor

@johnpaulkee johnpaulkee commented Jun 25, 2019 •
edited
Loading

Add managed instances swagger to 2018-06-01-preview.
Main changes include moving ManagedInstances_ListByInstancePool over from 2015-05-01-preview over to 2018-06-01-preview, updating sql README.md to reference 2018-06-01-preview/managedInstances swagger.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 25, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 1b3affb)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5771

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2635

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5096

@AutorestCI AutorestCI mentioned this pull request Jun 25, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3004

This was referenced Jun 25, 2019
Merged
Merged
@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2019
@anuchandy
Copy link
Member

@jaredmoo SQL swagger please review.

Added "ARM review request" since the PR removes an API and introduces new property?

jaredmoo
jaredmoo suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments. Otherwise approved.

...fication/sql/resource-manager/Microsoft.Sql/preview/2015-05-01-preview/managedInstances.json Outdated Show resolved Hide resolved
...fication/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/managedInstances.json Outdated Show resolved Hide resolved
@johnpaulkee
Copy link
Contributor Author

Will remove maintenance window changes from this PR.

@johnpaulkee
Copy link
Contributor Author

Please address comments. Otherwise approved.

Thanks @jaredmoo - I've addressed comments.

@johnpaulkee
Copy link
Contributor Author

johnpaulkee commented Jun 25, 2019 •
edited
Loading

@jaredmoo SQL swagger please review.

Added "ARM review request" since the PR removes an API and introduces new property?

I removed the new property section.
The API ManagedInstanceListByInstancePool is moved from 2015-05-01-preview to 2018-06-01-preview, this API is new and not yet published.

@ravbhatnagar
Copy link
Contributor

@johnpaulkee - are you dropping support for this one API from 2015 preview? Whats the usage of this API in 2015 preview. For SQL, even though this API is marked as -preview, since it has been in this state for ever, its considered as perpetual preview. So, we don't want to break customers using this API -version.
Are there other managedInstances APIs that will be moved to 2018 preview?

@johnpaulkee
Copy link
Contributor Author

johnpaulkee commented Jun 25, 2019 •
edited
Loading

@ravbhatnagar currently there is no usage for this ManagedInstance_ListByInstancePool API in 2015-05-01-preview and we plan to support it in 2018-06-01-preview. Customer's won't be broken using the newer API version as there are no clients/customers using it yet.

Currently this API doesn't work in 2015-05-01-preview as its request url starts with .../instancePool/{ipName}/managedInstances and currently in ARM manifest, instance pools only allows the 2018-06-01-preview api version. The migration of this API from 2015-05-01-preview over to 2018-06-01-preview will fix this and allow actual support of this API from SDKs.

There are no other managed instance APIs that we are moving from 2015-05-01-preview, and support for 2018-06-01-preview already exists in production for all other managed instance APIs.

@ravbhatnagar
Copy link
Contributor

Thanks for confirming @johnpaulkee . Signing off from ARM side since it was confirmed that there is no usage of this API and it wouldnt have worked since in ARM the supported API version is the new one.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 25, 2019
@johnpaulkee
Copy link
Contributor Author

Thanks for confirming @johnpaulkee . Signing off from ARM side since it was confirmed that there is no usage of this API and it wouldnt have worked since in ARM the supported API version is the new one.

Thank you @ravbhatnagar.

@anuchandy
Copy link
Member

Adding "breaking-change" tag since 2015-05-01-preview removes an API.

@anuchandy anuchandy merged commit 5afe3f8 into Azure:master Jun 25, 2019
@johnpaulkee johnpaulkee deleted the mi2018 branch June 25, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy left review comments

@jaredmoo jaredmoo jaredmoo approved these changes

Assignees

@anuchandy anuchandy

@jaredmoo jaredmoo

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johnpaulkee @AutorestCI @azuresdkci @anuchandy @ravbhatnagar @jaredmoo