Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start & shutdown Hana APIs to swagger spec. #6428

Merged
merged 8 commits into from
Jun 26, 2019
Merged

Add start & shutdown Hana APIs to swagger spec. #6428

merged 8 commits into from
Jun 26, 2019

Conversation

vipulha
Copy link
Contributor

@vipulha vipulha commented Jun 24, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 43fb475)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 24, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6105

@AutorestCI AutorestCI mentioned this pull request Jun 24, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3252

@AutorestCI AutorestCI mentioned this pull request Jun 24, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5100

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

lagalbra
lagalbra approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@lagalbra lagalbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check the box in the PR description to "wait for ARM feedback" since you added new APIs in this PR.

@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2019
@amarzavery
Copy link
Contributor

ARM team needs to sign-off since new APIs are added. From my perspective, the PR looks good.

ravbhatnagar
ravbhatnagar reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vipulha just one minor comment. please address.

...naonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json Show resolved Hide resolved
@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 25, 2019
@vipulha
Copy link
Contributor Author

vipulha commented Jun 26, 2019

@vipulha just one minor comment. please address.
Added default response.

@vipulha vipulha closed this Jun 26, 2019
@vipulha vipulha reopened this Jun 26, 2019
@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019
@amarzavery amarzavery merged commit 0bc701c into Azure:master Jun 26, 2019
@vipulha vipulha deleted the dev/vipulha/addstartstophanaapi branch July 12, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@PakDLiu PakDLiu PakDLiu approved these changes

@lagalbra lagalbra lagalbra approved these changes

@amarzavery amarzavery amarzavery approved these changes

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vipulha @AutorestCI @azuresdkci @amarzavery @ravbhatnagar @lagalbra @PakDLiu