Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaitForARMFeedback: GalleryApplication API #6411

Merged
merged 1 commit into from
Jul 9, 2019
Merged

WaitForARMFeedback: GalleryApplication API #6411

merged 1 commit into from
Jul 9, 2019

Conversation

koralski
Copy link
Contributor

@koralski koralski commented Jun 21, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 21, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 0fd6748)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jun 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5853

@AutorestCI AutorestCI mentioned this pull request Jun 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5212

@AutorestCI
Copy link

AutorestCI commented Jun 21, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@koralski
Copy link
Contributor Author

Re: lintdiff failures:
The new API for application gallery does not implement PATCH so this new errors are expected.

The existing API for Gallery Image remains the same (body and parameters) although some base definitions are refactored to be used by Gallery Application.

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 24, 2019
@koralski koralski mentioned this pull request Jun 26, 2019
Closed
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jun 26, 2019
Closed
@ravbhatnagar
Copy link
Contributor

@koralski - please set up a call to go over the review. I sent you an email about it. Thanks!

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewMeetingRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 2, 2019
@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@sergey-shandar sergey-shandar merged commit 2a65faa into Azure:master Jul 9, 2019
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@koralski @celikcigdem
GalleryApplication API (Azure#6411)
857bd70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@huangpf huangpf Awaiting requested review from huangpf

@hyonholee hyonholee Awaiting requested review from hyonholee

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@koralski @AutorestCI @azuresdkci @jhendrixMSFT @ravbhatnagar @sergey-shandar