Add new API version 2019-07-01 for SIG swagger spec #6400

jerryc3 · 2019-06-20T22:21:26Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…le writable

openapi-sdkautomation · 2019-06-20T22:21:28Z

SDK Automation [Logs] (Generated from 46c41c8, Iteration 8)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/compute/azure-mgmt-compute [Logs] [Instructions]
- azure-mgmt-compute-5.0.0.zip
- azure_mgmt_compute-5.0.0-py2.py3-none-any.whl

Java: Azure/azure-sdk-for-java [Logs] [Diff]

compute/resource-manager/v2017_03_30 [Logs]
compute/resource-manager/v2017_09_01 [Logs] [Instructions]
compute/resource-manager/v2017_12_01 [Logs]
compute/resource-manager/v2018_04_01 [Logs] [Instructions]

JavaScript: Azure/azure-sdk-for-js [Logs]

No packages generated.

Go: Azure/azure-sdk-for-go [Logs]

No packages generated.

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.28.0.gem
data/compute [Logs]

AutorestCI · 2019-06-20T22:23:41Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-20T22:24:12Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5853

AutorestCI · 2019-06-20T22:27:33Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5283

AutorestCI · 2019-06-20T22:28:28Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2019-06-20T23:03:19Z

Can one of the admins verify this patch?

jhendrixMSFT · 2019-06-26T17:14:39Z

@AutorestCI regenerate azure-sdk-for-go

ravbhatnagar · 2019-06-26T18:00:11Z

Two properties changed to writable from readonly. Signing off from ARM side.

...ource-manager/Microsoft.Compute/stable/2019-07-01/examples/CreateOrUpdateASimpleGallery.json

...e/resource-manager/Microsoft.Compute/stable/2019-07-01/examples/GetAGalleryImageVersion.json

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/gallery.json

vanbasten2323 · 2019-07-02T17:15:42Z

LGTM

jhendrixMSFT · 2019-07-03T16:19:28Z

@jerryc3 this looks good from SDK perspective. Does anybody else need to review/sign off?

jerryc3 · 2019-07-03T17:38:38Z

@jerryc3 this looks good from SDK perspective. Does anybody else need to review/sign off?

Hi Joel, Thanks for the review! The code owners Pengfei/Hyonho still need to take a look. I also got informed yesterday that my team is trying to add another small field. I think it would be better to add it to this PR so SDK team only has to regenerate once - I will update this PR as soon as it is ready.

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/gallery.json

vanbasten23 · 2019-07-10T18:00:00Z

LGTM

jhendrixMSFT · 2019-07-17T16:41:16Z

@jerryc3 is this ready now?

jerryc3 · 2019-07-17T22:14:27Z

@jerryc3 is this ready now?

This is ready! I have asked Hyonho to look at it and then we can merge as soon as he signs off.

hyonholee · 2019-07-17T22:35:29Z

LGTM. Thanks.

jerryc3 · 2019-07-17T22:41:07Z

@jhendrixMSFT Got all required approvals. Thanks!

Jerry Chan added 2 commits June 20, 2019 14:16

copy over gallery spec from 2019-03-01 api version

b82d5e8

remove PublishingProfile.source, make GalleryImageVersionStorageProfi…

2ff6882

…le writable

jerryc3 requested review from huangpf and hyonholee as code owners June 20, 2019 22:21

Jerry Chan added 2 commits June 20, 2019 15:32

fix json

3d3df8e

remove required source

4b12141

azuresdkci assigned jhendrixMSFT Jun 20, 2019

azuresdkci requested a review from jhendrixMSFT June 20, 2019 23:05

add 2019-07-01 to Go SDK

d3aa4e8

AutorestCI mentioned this pull request Jun 20, 2019

[AutoPR compute/resource-manager] [DO NOT MERGE] Add new API version 2019-07-01 for SIG swagger spec Azure/azure-sdk-for-go#5067

Closed

jhendrixMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2019

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR compute/resource-manager] [DO NOT MERGE] Add new API version 2019-07-01 for SIG swagger spec Azure/azure-sdk-for-go#5133

Closed

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2019

vanbasten2323 reviewed Jun 27, 2019

View reviewed changes

...ource-manager/Microsoft.Compute/stable/2019-07-01/examples/CreateOrUpdateASimpleGallery.json Outdated Show resolved Hide resolved

vanbasten2323 reviewed Jun 27, 2019

View reviewed changes

...e/resource-manager/Microsoft.Compute/stable/2019-07-01/examples/GetAGalleryImageVersion.json Show resolved Hide resolved

vanbasten2323 reviewed Jun 27, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/gallery.json Outdated Show resolved Hide resolved

Jerry Chan added 2 commits July 1, 2019 14:52

update examples with correct api version and add 1 more example

4c3a041

Merge branch 'master' of https://github.com/jerryc3/azure-rest-api-specs

14f8153

jerryc3 changed the title ~~[DO NOT MERGE] Add new API version 2019-07-01 for SIG swagger spec~~ Add new API version 2019-07-01 for SIG swagger spec Jul 1, 2019

add reference to example{

a0a951d

Jerry Chan added 2 commits July 3, 2019 17:20

Add HyperVGeneration field

d69ed60

Make hyperVGeneration field same as DiskRPs

46c41c8

AutorestCI mentioned this pull request Jul 9, 2019

[AutoPR compute/resource-manager] Add new API version 2019-07-01 for SIG swagger spec Azure/azure-sdk-for-python#6267

Merged

vanbasten23 reviewed Jul 10, 2019

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2019-07-01/gallery.json Show resolved Hide resolved

jhendrixMSFT approved these changes Jul 17, 2019

View reviewed changes

jhendrixMSFT merged commit 6b6a445 into Azure:master Jul 17, 2019

AutorestCI mentioned this pull request Jul 17, 2019

[AutoPR compute/resource-manager] Add new API version 2019-07-01 for SIG swagger spec Azure/azure-sdk-for-go#5282

Merged

hyonholee mentioned this pull request Jul 23, 2019

[Compute] Adding dedicated host APIs and update of Gallery APIs Azure/azure-sdk-for-net#7005

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new API version 2019-07-01 for SIG swagger spec #6400

Add new API version 2019-07-01 for SIG swagger spec #6400

jerryc3 commented Jun 20, 2019

openapi-sdkautomation bot commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

azuresdkci commented Jun 20, 2019

jhendrixMSFT commented Jun 26, 2019

ravbhatnagar commented Jun 26, 2019

vanbasten2323 commented Jul 2, 2019

jhendrixMSFT commented Jul 3, 2019

jerryc3 commented Jul 3, 2019 •

edited

Loading

vanbasten23 commented Jul 10, 2019

jhendrixMSFT commented Jul 17, 2019

jerryc3 commented Jul 17, 2019

hyonholee commented Jul 17, 2019

jerryc3 commented Jul 17, 2019

Add new API version 2019-07-01 for SIG swagger spec #6400

Add new API version 2019-07-01 for SIG swagger spec #6400

Conversation

jerryc3 commented Jun 20, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 20, 2019 • edited Loading

SDK Automation [Logs] (Generated from 46c41c8, Iteration 8)

AutorestCI commented Jun 20, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 20, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 20, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 20, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jun 20, 2019

jhendrixMSFT commented Jun 26, 2019

ravbhatnagar commented Jun 26, 2019

vanbasten2323 commented Jul 2, 2019

jhendrixMSFT commented Jul 3, 2019

jerryc3 commented Jul 3, 2019 • edited Loading

vanbasten23 commented Jul 10, 2019

jhendrixMSFT commented Jul 17, 2019

jerryc3 commented Jul 17, 2019

hyonholee commented Jul 17, 2019

jerryc3 commented Jul 17, 2019

openapi-sdkautomation bot commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

AutorestCI commented Jun 20, 2019 •

edited

Loading

jerryc3 commented Jul 3, 2019 •

edited

Loading