[Microsoft.Advisor] Add applicableScenarios property to metadata entity properties. (API is not live yet) #6067

mudit794 · 2019-05-22T18:07:25Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2019-05-22T18:32:05Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-22T19:09:28Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5133

AutorestCI · 2019-05-22T19:10:21Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3200

AutorestCI · 2019-05-22T19:12:08Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4874

REST Spec PR 'Azure/azure-rest-api-specs#6067' REST Spec PR Author 'mudit794' REST Spec PR Last commit

adxsdknet · 2019-05-22T19:15:04Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6390
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@2fc54b3
adxsdknet/azure-sdk-for-net@ced452e

AutorestCI · 2019-05-22T19:20:17Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

nschonni · 2019-05-22T20:20:16Z

To make the spelling happy, you'd need to add "Alertable" to the words array in https://github.com/Azure/azure-rest-api-specs/blob/master/cSpell.json#L5

merge from azure master

merge from master to local breanch

AutorestCI · 2019-05-22T21:51:04Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp0vj1krb5/rest/specification/advisor/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpvoy9umc2']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

mudit794 · 2019-05-22T21:53:48Z

To make the spelling happy, you'd need to add "Alertable" to the words array in https://github.com/Azure/azure-rest-api-specs/blob/master/cSpell.json#L5

Added "Alertable" in spell.json.

node SDK failure is known thing. It is due to some infra issue.

specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json

REST Spec PR 'Azure/azure-rest-api-specs#6067' REST Spec PR Author 'mudit794' REST Spec PR Last commit

ryansbenson

Signed off from ARMs side

* .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#6067' REST Spec PR Author 'mudit794' REST Spec PR Last commit * .NET SDK Resource Provider:'Advisor' REST Spec PR 'Azure/azure-rest-api-specs#6067' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 added 3 commits May 22, 2019 11:03

Add is alertable field to metadata entity properties

2f95fb1

add is alertable property to get metadata example

62cc64c

add is alertable property to example in list metadata

f5a6950

mudit794 changed the title ~~Add isAlertable property to metadata entity properties. (API is not live yet)~~ [Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet) May 22, 2019

AutorestCI mentioned this pull request May 22, 2019

[AutoPR advisor/resource-manager] [Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet) Azure/azure-sdk-for-python#5415

Merged

azuresdkci assigned sergey-shandar May 22, 2019

azuresdkci requested a review from sergey-shandar May 22, 2019 19:09

AutorestCI mentioned this pull request May 22, 2019

[AutoPR advisor/resource-manager] [Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet) Azure/azure-sdk-for-js#3126

Closed

AutorestCI mentioned this pull request May 22, 2019

[AutoPR advisor/resource-manager] [Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet) Azure/azure-sdk-for-go#4858

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 22, 2019

.NET SDK Resource Provider:'Advisor'

2fc54b3

REST Spec PR 'Azure/azure-rest-api-specs#6067' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 added 5 commits May 22, 2019 13:44

add alertable to cspell.json

ec48de8

Delete cSpell.json

22672e9

Merge pull request #1 from Azure/master

7ffcb4e

merge from azure master

Merge pull request #2 from mudit794/master

952833f

merge from master to local breanch

add alertable to cspell.json

cb86feb

mudit794 mentioned this pull request May 22, 2019

[Microsoft.ResourceHealth] Add applicableScenarios property to metadata entity properties (API is not live yet) #6068

Merged

5 tasks

mudit794 added 2 commits May 22, 2019 13:55

Add it with upper case "Alertable"

bb717bd

correct the order alphabetically for alertable

67d818c

AutorestCI mentioned this pull request May 22, 2019

[AutoPR advisor/resource-manager] [Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet) Azure/azure-sdk-for-java#3748

Closed

ryansbenson reviewed May 23, 2019

View reviewed changes

specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json Outdated Show resolved Hide resolved

ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 23, 2019

ryansbenson added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 23, 2019

Remove alertable from cspell.json

ae518a2

AutorestCI mentioned this pull request May 24, 2019

[AutoPR advisor/resource-manager] [Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet) Azure/azure-sdk-for-js#3188

Merged

mudit794 added 5 commits May 24, 2019 10:24

revert cspell.json

b8a58bc

revert cspell.json

bc4d54b

Add applicable scenarios property

0d63fc1

Update example to include applicable scenarios

5c60efa

Update list metadata example to include applicableScenarios

f4fc112

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 24, 2019

.NET SDK Resource Provider:'Advisor'

ced452e

REST Spec PR 'Azure/azure-rest-api-specs#6067' REST Spec PR Author 'mudit794' REST Spec PR Last commit

mudit794 changed the title ~~[Microsoft.Advisor] Add isAlertable property to metadata entity properties. (API is not live yet)~~ [Microsoft.Advisor] Add applicableScenarios property to metadata entity properties. (API is not live yet) May 24, 2019

ryansbenson reviewed May 24, 2019

View reviewed changes

sergey-shandar merged commit 657587d into Azure:master May 24, 2019

mudit794 deleted the advisor/AddAlertFieldToMetadata branch May 24, 2019 21:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Microsoft.Advisor] Add applicableScenarios property to metadata entity properties. (API is not live yet) #6067

[Microsoft.Advisor] Add applicableScenarios property to metadata entity properties. (API is not live yet) #6067

mudit794 commented May 22, 2019 •

edited

Loading

azuresdkci commented May 22, 2019

AutorestCI commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

adxsdknet commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

nschonni commented May 22, 2019

AutorestCI commented May 22, 2019 •

edited

Loading

mudit794 commented May 22, 2019

ryansbenson left a comment

[Microsoft.Advisor] Add applicableScenarios property to metadata entity properties. (API is not live yet) #6067

[Microsoft.Advisor] Add applicableScenarios property to metadata entity properties. (API is not live yet) #6067

Conversation

mudit794 commented May 22, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented May 22, 2019

AutorestCI commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-go

adxsdknet commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-net

AutorestCI commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-ruby

nschonni commented May 22, 2019

AutorestCI commented May 22, 2019 • edited Loading

Automation for azure-sdk-for-java

mudit794 commented May 22, 2019

ryansbenson left a comment

Choose a reason for hiding this comment

mudit794 commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

adxsdknet commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading

AutorestCI commented May 22, 2019 •

edited

Loading