EventGrid: Swagger for API Version 2019-06-01 #6003

ahamad-MS · 2019-05-17T05:26:54Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-05-17T05:27:41Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmplasi2vi2/rest/specification/eventgrid/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpdd_hp4ul']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-05-17T05:28:05Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3015

AutorestCI · 2019-05-17T05:28:08Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5339

AutorestCI · 2019-05-17T05:30:00Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4831

nschonni · 2019-05-17T05:32:11Z

specification/eventgrid/resource-manager/Microsoft.EventGrid/stable/2019-06-01/EventGrid.json

+        "tags": [
+          "Topics"
+        ],
+        "summary": "List topics under a resource group.",


iterms -> items

Suggested change

"summary": "List topics under a resource group.",

"description": "The number of results to return per page for the list operation. Valid range for top parameter is 1 to 100. If not specified, the default number of results to be returned is 20 items per page.",

azuresdkci · 2019-05-17T05:32:39Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-17T05:32:53Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3703

adxsdknet · 2019-05-17T05:36:44Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6311
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@e6f855f
adxsdknet/azure-sdk-for-net@b763990

REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit

kalyanaj · 2019-05-17T17:29:15Z

specification/eventgrid/resource-manager/Microsoft.EventGrid/stable/2019-06-01/EventGrid.json

+            "description": "*** Error Responses: ***\n\n * 400 Bad Request.\n\n * 500 Internal Server Error."
+          }
+        },
+        "x-ms-examples": {


It looks like the earlier version had some more examples here, can you please double-check if they are still required?

ahamad-MS · 2019-05-17T19:12:27Z

@sarangan12 Can you please approve/merge the change if no more concerns?

sarangan12 · 2019-05-17T20:34:59Z

Adding ARM Review since this is a new version

ahamad-MS · 2019-05-17T21:49:33Z

@sarangan12
We are not introducing any new ARM changes. All the changes were already reviewed by ARM team in person and were part of previous preview Swagger.

ravbhatnagar · 2019-05-19T07:33:36Z

This is same as 2019-02-01-preview version. New resource type domains is being added. This has already been reviewed and approved by ARM for the preview. Signing off from ARM side.

* .NET SDK Resource Provider:'EventGrid' REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit * .NET SDK Resource Provider:'EventGrid' REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit

Ashraf Hamad added 2 commits May 16, 2019 17:21

Copy stable 2019-01-01 as baseline for stable 2019-06-01

e53318f

EventGrid: Swagger work for 2019-06-01 Api Version

c6e4afd

This was referenced May 17, 2019

[AutoPR eventgrid/resource-manager] EventGrid: Swagger for API Version 2019-06-01 Azure/azure-sdk-for-js#2978

Merged

[AutoPR eventgrid/resource-manager] EventGrid: Swagger for API Version 2019-06-01 Azure/azure-sdk-for-python#5289

Merged

AutorestCI mentioned this pull request May 17, 2019

[AutoPR eventgrid/resource-manager] EventGrid: Swagger for API Version 2019-06-01 Azure/azure-sdk-for-go#4822

Merged

nschonni reviewed May 17, 2019

View reviewed changes

AutorestCI mentioned this pull request May 17, 2019

[AutoPR eventgrid/resource-manager] EventGrid: Swagger for API Version 2019-06-01 Azure/azure-sdk-for-java#3679

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 17, 2019

.NET SDK Resource Provider:'EventGrid'

e6f855f

REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit

azuresdkci assigned sarangan12 May 17, 2019

azuresdkci requested a review from sarangan12 May 17, 2019 05:39

address CR comments and fix example

476ebd8

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 17, 2019

.NET SDK Resource Provider:'EventGrid'

b763990

REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit

Ashraf Hamad added 3 commits May 16, 2019 23:58

fix test

2f2f8f8

fix example

20fc5d6

fix example

5229f07

kalyanaj reviewed May 17, 2019

View reviewed changes

Add missing examples and fix others

d0fda3b

sarangan12 approved these changes May 17, 2019

View reviewed changes

sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 17, 2019

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 19, 2019

sarangan12 merged commit 0422237 into Azure:master May 20, 2019

ahamad-MS deleted the master branch March 3, 2020 03:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EventGrid: Swagger for API Version 2019-06-01 #6003

EventGrid: Swagger for API Version 2019-06-01 #6003

ahamad-MS commented May 17, 2019

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

nschonni May 17, 2019 •

edited

Loading

ahamad-MS May 17, 2019

azuresdkci commented May 17, 2019

AutorestCI commented May 17, 2019 •

edited

Loading

adxsdknet commented May 17, 2019 •

edited

Loading

kalyanaj May 17, 2019

ahamad-MS May 17, 2019

ahamad-MS commented May 17, 2019

sarangan12 commented May 17, 2019

ahamad-MS commented May 17, 2019

ravbhatnagar commented May 19, 2019

	"summary": "List topics under a resource group.",
	"description": "The number of results to return per page for the list operation. Valid range for top parameter is 1 to 100. If not specified, the default number of results to be returned is 20 items per page.",

EventGrid: Swagger for API Version 2019-06-01 #6003

EventGrid: Swagger for API Version 2019-06-01 #6003

Conversation

ahamad-MS commented May 17, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-go

nschonni May 17, 2019 • edited Loading

Choose a reason for hiding this comment

ahamad-MS May 17, 2019

Choose a reason for hiding this comment

azuresdkci commented May 17, 2019

AutorestCI commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-java

adxsdknet commented May 17, 2019 • edited Loading

Automation for azure-sdk-for-net

kalyanaj May 17, 2019

Choose a reason for hiding this comment

ahamad-MS May 17, 2019

Choose a reason for hiding this comment

ahamad-MS commented May 17, 2019

sarangan12 commented May 17, 2019

ahamad-MS commented May 17, 2019

ravbhatnagar commented May 19, 2019

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

nschonni May 17, 2019 •

edited

Loading

AutorestCI commented May 17, 2019 •

edited

Loading

adxsdknet commented May 17, 2019 •

edited

Loading