Instance pool usages #5894

johnpaulkee · 2019-05-08T22:22:12Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…d instances get by instance pool

…ges examples

AutorestCI · 2019-05-08T22:22:55Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2635

AutorestCI · 2019-05-08T22:24:02Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#5771

AutorestCI · 2019-05-08T22:26:32Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-05-08T22:26:36Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3877

johnpaulkee · 2019-05-08T22:28:37Z

I plan to add instancePoolUsages.json and instancePools.json (not in this review) in a separate PR, so merging with just these files after validation and review is ok.

azuresdkci · 2019-05-08T23:10:45Z

Can one of the admins verify this patch?

AutorestCI · 2019-05-08T23:37:15Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

ravbhatnagar · 2019-05-13T20:53:43Z

@johnpaulkee - The API signature and the response schema does not comply with ARM /usages contract. Please take a look - https://armwiki.azurewebsites.net/api_contracts/UsagesAPIContract.html

ravbhatnagar · 2019-05-19T08:07:00Z

We(ARM) will need to update the usages contract to cater to such scenarios. I Will have a proposal early next week. That way we can have consistency across Azure w.r.t getting usage data.

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json

sanjaiganesh · 2019-05-31T18:38:19Z

PR still needs to be updated per new usages spec (ARM). Gaurav is following up offline with the team.

In reply to: 493736164 [](ancestors = 493736164)

johnpaulkee · 2019-05-31T18:48:16Z

Acked on updated usages contract

openapi-sdkautomation · 2019-06-07T20:34:09Z

SDK Automation [Logs] (Generated from 73f5d68)

Python: Azure/azure-sdk-for-python

Package generation pending.

Java: Azure/azure-sdk-for-java

Package generation pending.

Go: Azure/azure-sdk-for-go

Package generation pending.

JavaScript: Azure/azure-sdk-for-js

Package generation pending.

Ruby: Azure/azure-sdk-for-ruby

Package generation pending.

johnpaulkee · 2019-06-07T20:37:28Z

PR still needs to be updated per new usages spec (ARM). Gaurav is following up offline with the team.

In reply to: 493736164 [](ancestors = 493736164)

I've updated swagger based on updated usages contract.
There is ongoing thread with ARM team to help us with this:

-	Provide exact standardized swagger, in particular:
o	prescribed operation id’s (e.g. “InstancePools_ListUsages”? “Usages_ListByInstancePool”),
o	schema names
o	parameter names 
o	descriptions,
-	Work with Samer’s team to come up with validators for these?

@ravbhatnagar please validate when possible :) thank you.

sergey-shandar · 2019-06-12T23:16:18Z

@ravbhatnagar @sanjaiganesh any update on ARM review?

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json

…eName -> Name

johnpaulkee · 2019-06-14T17:11:38Z

Ping @ravbhatnagar for review.

ravbhatnagar · 2019-06-14T17:29:26Z

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json

+{
+  "swagger": "2.0",
+  "info": {
+    "version": "2.0",


this should be the api-version

fixed. thanks @ravbhatnagar 👍

ravbhatnagar · 2019-06-14T17:31:22Z

@johnpaulkee - looks good. just the api-version needs to be fixed. Signing off considering the api-version value will be fixed.

johnpaulkee · 2019-06-14T18:06:46Z

Thanks @ravbhatnagar , I've updated api-version.
@sergey-shandar should be good for review now.

johnpaulkee · 2019-06-17T18:23:07Z

ping @sergey-shandar for review.
I've updated the instancePoolUsages.json to usages.json FYI.

specification/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/usages.json

…into instancePoolUsages

johnpaulkee · 2019-06-17T22:37:21Z

Thanks @sergey-shandar !

…5894) * AzureSphere: Fix of response of generateDefaultDeviceGroups action. Work item: https://dev.azure.com/msazuresphere/4x4/_workitems/edit/127676 * Azure Sphere fix typo on example

John Paul Kee added 5 commits February 19, 2019 10:17

Initializing instance pools swagger and examples - no usages / manage…

5251cc1

…d instances get by instance pool

Sync latest

df56164

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

224291b

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

c1facdf

Add instance pool usages, use common resources, and instance pool usa…

1ffaa53

…ges examples

azuresdkci assigned sergey-shandar May 8, 2019

azuresdkci requested a review from sergey-shandar May 8, 2019 22:22

AutorestCI mentioned this pull request May 8, 2019

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-js#2774

Closed

AutorestCI mentioned this pull request May 8, 2019

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-java#3592

Merged

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 10, 2019

ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 13, 2019

sanjaiganesh reviewed May 31, 2019

View reviewed changes

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json Outdated Show resolved Hide resolved

sanjaiganesh reviewed May 31, 2019

View reviewed changes

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json Outdated Show resolved Hide resolved

sanjaiganesh reviewed May 31, 2019

View reviewed changes

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json Outdated Show resolved Hide resolved

Updates to instance pool usages based on updated ARM usages contract

7ae8a2a

johnpaulkee requested a review from jaredmoo as a code owner June 7, 2019 20:34

This was referenced Jun 7, 2019

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-python#5755

Closed

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-ruby#2567

Closed

AutorestCI mentioned this pull request Jun 7, 2019

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-js#3596

Closed

chidmdxx reviewed Jun 12, 2019

View reviewed changes

...cation/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/instancePoolUsages.json Outdated Show resolved Hide resolved

Update instance pool usages swagger based on arm review - rename Usag…

b1345e5

…eName -> Name

This was referenced Jun 14, 2019

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-ruby#2622

Merged

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-js#3810

Closed

ravbhatnagar reviewed Jun 14, 2019

View reviewed changes

Updating version

488152d

John Paul Kee added 2 commits June 17, 2019 11:15

Update instance pool usages operation id

aa07fa3

update to usages.json since we're using new operation group

6c0ff53

sergey-shandar suggested changes Jun 17, 2019

View reviewed changes

specification/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/usages.json Show resolved Hide resolved

John Paul Kee added 3 commits June 17, 2019 13:24

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …

2ea7281

…into instancePoolUsages

add usages to readme.md

a291542

fix extra line

73f5d68

sergey-shandar approved these changes Jun 17, 2019

View reviewed changes

sergey-shandar merged commit 5587a88 into Azure:master Jun 17, 2019

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR sql/resource-manager] Instance pool usages Azure/azure-sdk-for-js#3876

Merged

johnpaulkee deleted the instancePoolUsages branch June 17, 2019 22:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instance pool usages #5894

Instance pool usages #5894

johnpaulkee commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

johnpaulkee commented May 8, 2019

azuresdkci commented May 8, 2019

AutorestCI commented May 8, 2019 •

edited

Loading

ravbhatnagar commented May 13, 2019

ravbhatnagar commented May 19, 2019 •

edited

Loading

sanjaiganesh commented May 31, 2019

johnpaulkee commented May 31, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 7, 2019 •

edited

Loading

johnpaulkee commented Jun 7, 2019 •

edited

Loading

sergey-shandar commented Jun 12, 2019

johnpaulkee commented Jun 14, 2019

ravbhatnagar Jun 14, 2019

johnpaulkee Jun 14, 2019

ravbhatnagar commented Jun 14, 2019

johnpaulkee commented Jun 14, 2019

johnpaulkee commented Jun 17, 2019

johnpaulkee commented Jun 17, 2019

Instance pool usages #5894

Instance pool usages #5894

Conversation

johnpaulkee commented May 8, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented May 8, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented May 8, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 8, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented May 8, 2019 • edited Loading

Automation for azure-sdk-for-js

johnpaulkee commented May 8, 2019

azuresdkci commented May 8, 2019

AutorestCI commented May 8, 2019 • edited Loading

Automation for azure-sdk-for-java

ravbhatnagar commented May 13, 2019

ravbhatnagar commented May 19, 2019 • edited Loading

sanjaiganesh commented May 31, 2019

johnpaulkee commented May 31, 2019 • edited Loading

openapi-sdkautomation bot commented Jun 7, 2019 • edited Loading

SDK Automation [Logs] (Generated from 73f5d68)

johnpaulkee commented Jun 7, 2019 • edited Loading

sergey-shandar commented Jun 12, 2019

johnpaulkee commented Jun 14, 2019

ravbhatnagar Jun 14, 2019

Choose a reason for hiding this comment

johnpaulkee Jun 14, 2019

Choose a reason for hiding this comment

ravbhatnagar commented Jun 14, 2019

johnpaulkee commented Jun 14, 2019

johnpaulkee commented Jun 17, 2019

johnpaulkee commented Jun 17, 2019

johnpaulkee commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

AutorestCI commented May 8, 2019 •

edited

Loading

ravbhatnagar commented May 19, 2019 •

edited

Loading

johnpaulkee commented May 31, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jun 7, 2019 •

edited

Loading

johnpaulkee commented Jun 7, 2019 •

edited

Loading