-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for App Insights/Log Analytics purge #5851
Conversation
Automation for azure-sdk-for-rubyA PR has been created for you: |
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-jsA PR has been created for you: |
Automation for azure-sdk-for-javaEncountered a Subprocess error: (azure-sdk-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmpx084f4u7/rest/specification/applicationinsights/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpk5aeehjy'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
Automation for azure-sdk-for-goA PR has been created for you: |
Can one of the admins verify this patch? |
...pplicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/components_API.json
Outdated
Show resolved
Hide resolved
...ts/resource-manager/Microsoft.OperationalInsights/stable/2015-03-20/OperationalInsights.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
behaviour -> behavior
The original spelling is correct for me, but I think the docs are generally US spelling
…perationalInsights/stable/2015-03-20/OperationalInsights.json Co-Authored-By: alexeldeib <alexeldeib@gmail.com>
…nsights/stable/2015-05-01/components_API.json Co-Authored-By: alexeldeib <alexeldeib@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it, can you also fix the model validation failures. I understand those failures are not related to your changes, but take this opportunity to fix the examples.
- Add required parameter 'savedSearchId' in the example 'WorkspacesDeleteSavedSearches'
- Add required parameter 'savedSearchId' in the example 'WorkspacesSavedSearchesCreateOrUpdate'
There are additional similar errors take a look at
https://dev.azure.com/azure-sdk/public/_build/results?buildId=25819
Sure, these look simple enough to fix. cc @yoramsinger as FYI since I'm touching saved search (I think this is you Yoram?). |
Look fine. |
Yeah, ended up being very simple. @shahabhijeet let me know if there's anything else |
@shahabhijeet I noticed this hasn't merged, seems like a bug in the .NET test pipeline handling multiple RPs?
|
@nschonni @shahabhijeet any update here? Circling back because I checked the docs and realized the PR still hadn't merged.. Our team receives customer questions on the allowed operators in this doc fairly regularly, would love to get this change merged. |
Sorry, I'm not an MS employee. There is an internal link in the PR template that might have steps/contacts for getting something pushed forward, but I can't see whet it says 😄 |
Sorry @nschonni! I assumed we simply hadn't crossed paths yet 😄 @lmazuel @sarangan12 could one of you please take a look at the above error? |
SDK Automation [Logs] (Generated from 625784c)Python: Azure/azure-sdk-for-python
Java: Azure/azure-sdk-for-java
Go: Azure/azure-sdk-for-go
JavaScript: Azure/azure-sdk-for-js
Ruby: Azure/azure-sdk-for-ruby
|
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.