Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for App Insights/Log Analytics purge #5851

Merged
merged 7 commits into from
Jun 10, 2019

Conversation

alexeldeib
Copy link
Contributor

@alexeldeib alexeldeib commented May 3, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 3, 2019

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2440

@AutorestCI
Copy link

AutorestCI commented May 3, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#5777

@AutorestCI
Copy link

AutorestCI commented May 3, 2019

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#3621

@AutorestCI
Copy link

AutorestCI commented May 3, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpx084f4u7/rest/specification/applicationinsights/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpk5aeehjy']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented May 3, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4742

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behaviour -> behavior
The original spelling is correct for me, but I think the docs are generally US spelling

nschonni and others added 2 commits May 2, 2019 22:27
…perationalInsights/stable/2015-03-20/OperationalInsights.json

Co-Authored-By: alexeldeib <alexeldeib@gmail.com>
…nsights/stable/2015-05-01/components_API.json

Co-Authored-By: alexeldeib <alexeldeib@gmail.com>
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, can you also fix the model validation failures. I understand those failures are not related to your changes, but take this opportunity to fix the examples.

  1. Add required parameter 'savedSearchId' in the example 'WorkspacesDeleteSavedSearches'
  2. Add required parameter 'savedSearchId' in the example 'WorkspacesSavedSearchesCreateOrUpdate'
    There are additional similar errors take a look at
    https://dev.azure.com/azure-sdk/public/_build/results?buildId=25819

@alexeldeib
Copy link
Contributor Author

Sure, these look simple enough to fix. cc @yoramsinger as FYI since I'm touching saved search (I think this is you Yoram?).

@yoramsinger
Copy link
Contributor

Look fine.

@alexeldeib
Copy link
Contributor Author

Yeah, ended up being very simple. @shahabhijeet let me know if there's anything else

@alexeldeib
Copy link
Contributor Author

@shahabhijeet I noticed this hasn't merged, seems like a bug in the .NET test pipeline handling multiple RPs?

Successfully fetched all files modified in the REST spec PR. Calculating the resource provider name.
15:55:57      1>c:\Jenkins\workspace\DotNetSwaggerToSdkCI\scripts\stostools\SToS.proj(17,9): error : Exception: Cannot handle multiple RPs: applicationinsights/resource-manager, operationalinsights/resource-manager

@alexeldeib
Copy link
Contributor Author

@nschonni @shahabhijeet any update here? Circling back because I checked the docs and realized the PR still hadn't merged.. Our team receives customer questions on the allowed operators in this doc fairly regularly, would love to get this change merged.

@nschonni
Copy link
Contributor

nschonni commented Jun 5, 2019

Sorry, I'm not an MS employee. There is an internal link in the PR template that might have steps/contacts for getting something pushed forward, but I can't see whet it says 😄

@alexeldeib
Copy link
Contributor Author

Sorry @nschonni! I assumed we simply hadn't crossed paths yet 😄

@lmazuel @sarangan12 could one of you please take a look at the above error?

@shahabhijeet shahabhijeet merged commit a9b42c0 into Azure:master Jun 10, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 10, 2019

SDK Automation [Logs] (Generated from 625784c)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.
Pending Ruby: Azure/azure-sdk-for-ruby
  • Package generation pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants