Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert node public ip support from 2019-04-01 model. #5841

Merged
merged 1 commit into from
May 2, 2019
Merged

Revert node public ip support from 2019-04-01 model. #5841

merged 1 commit into from
May 2, 2019

Conversation

JunSun17
Copy link
Contributor

@JunSun17 JunSun17 commented May 2, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request May 2, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2610

@azuresdkci azuresdkci requested a review from dsgouda May 2, 2019 17:45
@AutorestCI AutorestCI mentioned this pull request May 2, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5009

@AutorestCI
Copy link

AutorestCI commented May 2, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented May 2, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

dsgouda
dsgouda reviewed May 2, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change on a stable version. Were the SDKs published for this API version?

@dsgouda dsgouda added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 2, 2019
@AutorestCI AutorestCI mentioned this pull request May 2, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 2, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4738

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 2, 2019
@adxsdknet
.NET SDK Resource Provider:'ContainerService'
ff48f1d 
REST Spec PR 'Azure/azure-rest-api-specs#5841'
REST Spec PR Author 'JunSun17'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6053
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@ff48f1d

@JunSun17
Copy link
Contributor Author

JunSun17 commented May 2, 2019

This is a breaking change on a stable version. Were the SDKs published for this API version?

How can I check if the SDK has been published? If so, the intention here is still to push out this change and re-publish the SDK again.

@xizha162
Copy link
Contributor

xizha162 commented May 2, 2019

@dsgouda, I have not started the API release process yet.

@dsgouda dsgouda removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels May 2, 2019
dsgouda
dsgouda approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved since no SDKs have been published yet

@dsgouda dsgouda merged commit 8ea3810 into Azure:master May 2, 2019
@veronicagg
Copy link
Contributor

I just checked the SDKs and couldn't find the property that was reverted in this PR in them, so should not cause issues on the SDKs.

dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 2, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'ContainerService' (#6053)
15bbe5e 
REST Spec PR 'Azure/azure-rest-api-specs#5841'
REST Spec PR Author 'JunSun17'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'ContainerService' (Azure#6053)
efccbec 
REST Spec PR 'Azure/azure-rest-api-specs#5841'
REST Spec PR Author 'JunSun17'
REST Spec PR Last commit
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@Basant2619
Added MSI object Id in Monitor response (#5841)
3ca8f18 
* Added readonly MSI object Id in Monitor response

* object id

* readonly property

* MSI ARM ID instead of object ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JunSun17 @AutorestCI @azuresdkci @adxsdknet @xizha162 @veronicagg @dsgouda