Sync from master. Improved code style

.travis.yml

@@ -8,45 +8,12 @@ services:
 env:
   matrix:
     - MODE=branchStrategy
-    - MODE=semantic PR_ONLY=true CHECK_NAME="Semantic Validator"
-    - MODE=model PR_ONLY=true CHECK_NAME="Model Validator"
-    - MODE=BreakingChange PR_ONLY=true CHECK_NAME="Breaking Changes"
-    - MODE=lintdiff PR_ONLY=true CHECK_NAME="Linter Diff" NODE_OPTIONS=--max-old-space-size=8192
 matrix:
   fast_finish: true
-  allow_failures:
-    - env: MODE=model PR_ONLY=true CHECK_NAME="Model Validator"
-    - env: MODE=BreakingChange PR_ONLY=true CHECK_NAME="Breaking Changes"
 install: true
 script:
   - >-
     if [[ $MODE == 'branchStrategy' ]]; then
       # Check to ensure CI is not executing for a PR against the master branch in the private repository
       ! [[ $TRAVIS_PULL_REQUEST != 'false' && $TRAVIS_REPO_SLUG == 'Azure/azure-rest-api-specs-pr' && $TRAVIS_BRANCH == 'master' ]]
     fi
-  - >-
-    if [[ $MODE == 'semantic' ]]; then
-      npm install
-      npm run tsc
-      node scripts/semanticValidation.js
-    fi
-  - >-
-    if [[ $MODE == 'model' ]]; then
-      npm install
-      npm run tsc
-      node scripts/modelValidation.js
-    fi
-  - >-
-    if [[ $MODE == 'BreakingChange' ]]; then
-      scripts/install-dotnet.sh
-      npm install
-      npm run tsc
-      node scripts/breaking-change.js
-    fi
-  - >-
-    if [[ $MODE == 'lintdiff' ]]; then
-      scripts/install-dotnet.sh
-      npm install
-      npm run tsc
-      node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js
-    fi

.vscode/settings.json

@@ -19,5 +19,6 @@
             ],
             "url":"https://raw.githubusercontent.com/Azure/autorest/master/schema/composite-swagger.json"
         }
-    ]
+    ],
+    "typescript.tsdk": "node_modules\\typescript\\lib"
 }

CODEOWNERS

@@ -73,3 +73,4 @@
 /specification/timeseriesinsights/ @sandshadow
 /specification/trafficmanager/ @allencal @hrkulkarmsft
 /specification/web/ @lukaszstem @naveedaz @nking92
+/profile/ @shahabhijeet

azure-pipelines.yml

@@ -58,7 +58,6 @@ jobs:
 - job: "Avocado"
   pool:
     vmImage: 'Ubuntu 16.04'
-  continueOnError: true
   steps:
   - task: Npm@1
     displayName: 'npm install'
@@ -68,12 +67,11 @@ jobs:
     displayName: 'Avocado'
 
 - job: "BreakingChange"
-  condition: "not(variables['PRIVATE'])"
   pool:
     vmImage: 'Ubuntu 16.04'
   steps:
   - script: 'scripts/install-dotnet.sh'
-    displayName: 'Insall .Net'
+    displayName: 'Install .Net'
   - task: Npm@1
     displayName: 'npm install'
     inputs:
@@ -82,7 +80,6 @@ jobs:
     displayName: 'Breaking Changes'
 
 - job: "LintDiff"
-  condition: "not(variables['PRIVATE'])"
   variables:
     NODE_OPTIONS: '--max-old-space-size=8192'
   pool:

package.json

@@ -10,17 +10,18 @@
   "description": "Tests for Azure REST API Specifications",
   "license": "MIT",
   "devDependencies": {
-    "@azure/avocado": "^0.3.3",
-    "@azure/oad": "^0.5.1",
-    "@azure/rest-api-specs-scripts": "^0.1.8",
+    "@azure/avocado": "^0.4.1",
+    "@azure/oad": "^0.6.3",
+    "@azure/rest-api-specs-scripts": "^0.3.9",
     "@microsoft.azure/async-io": "^2.0.21",
     "@microsoft.azure/literate": "^1.0.25",
     "@microsoft.azure/polyfill": "^1.0.19",
-    "@octokit/rest": "^16.24.1",
+    "@octokit/rest": "^16.25.0",
     "@ts-common/commonmark-to-markdown": "^1.2.0",
     "@ts-common/fs": "0.2.0",
     "@types/fs-extra": "^5.0.5",
     "@types/js-yaml": "^3.12.1",
+    "@types/mocha": "^5.2.6",
     "@types/request": "^2.48.1",
     "fs-extra": "^7.0.1",
     "glob": "^7.1.3",
@@ -31,7 +32,7 @@
     "request": "^2.88.0",
     "request-promise-native": "^1.0.7",
     "ts-node": "^8.1.0",
-    "typescript": "^3.4.3",
+    "typescript": "^3.4.4",
     "z-schema": "^4.0.2"
   },
   "homepage": "https://github.com/azure/azure-rest-api-specs",

preproduction-azure-pipelines.yml

@@ -1,4 +1,4 @@
-name: "Preproduction CI for Azure Rest API speciications"
+name: "Preproduction CI for Azure Rest API specifications"
 
 trigger: none
 
@@ -13,6 +13,14 @@ variables:
 
 jobs:
 
+- job: "BranchProtection"
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  condition: and(variables['PRIVATE'], eq(variables['System.PullRequest.TargetBranch'], 'master'))
+  steps:
+  - script: '>&2 echo "the branch is protected"'
+    failOnStderr: true
+
 - job: "Syntax"
   pool:
     vmImage: 'Ubuntu 16.04'
@@ -30,7 +38,7 @@ jobs:
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'npm install -D @azure/rest-api-specs-scripts@0.2.21 @azure/oad@0.6.3'
+  - script: 'npm install -D @azure/rest-api-specs-scripts@0.3.9'
   - script: 'npm test -- test/syntax.js'
     displayName: 'Syntax validation'
 
@@ -42,7 +50,7 @@ jobs:
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'npm install -D @azure/rest-api-specs-scripts@0.2.21 @azure/oad@0.6.3'
+  - script: 'npm install -D @azure/rest-api-specs-scripts@0.3.9'
   - script: 'npm run tsc && node scripts/semanticValidation.js'
     displayName: 'Semantic Validation'
 
@@ -54,7 +62,7 @@ jobs:
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'npm install -D @azure/rest-api-specs-scripts@0.2.21 @azure/oad@0.6.3'
+  - script: 'npm install -D @azure/rest-api-specs-scripts@0.3.9'
   - script: 'npm run tsc && node scripts/modelValidation.js'
     displayName: 'Model Validation'
 
@@ -80,7 +88,7 @@ jobs:
     displayName: 'npm install'
     inputs:
       verbose: false
-  - script: 'npm install -D @azure/rest-api-specs-scripts@0.2.21 @azure/oad@0.6.3'
+  - script: 'npm install -D @azure/rest-api-specs-scripts@0.3.9'
   - script: 'npm run tsc && node scripts/breaking-change.js'
     displayName: 'Breaking Changes'
 
@@ -96,37 +104,6 @@ jobs:
       verbose: false
   - script: 'scripts/install-dotnet.sh'
     displayName: 'install .Net'
-  - script: 'npm install -D @azure/rest-api-specs-scripts@0.2.21 @azure/oad@0.6.3'
+  - script: 'npm install -D @azure/rest-api-specs-scripts@0.3.9'
   - script: 'npm run tsc && node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js'
     displayName: 'LintDiff'
-
-- job: "SDK"
-  timeoutInMinutes: 120
-  strategy:
-    matrix:
-      ruby:
-        AZURE_SDK_REPO: azure-sdk-for-ruby
-        AZURE_SDK_PARAMS: ''
-      java:
-        AZURE_SDK_REPO: azure-sdk-for-java
-        AZURE_SDK_PARAMS: ''
-      javascript:
-        AZURE_SDK_REPO: azure-sdk-for-js
-        AZURE_SDK_PARAMS: ''
-      node:
-        AZURE_SDK_REPO: azure-sdk-for-node
-        AZURE_SDK_PARAMS: ''
-      python:
-        AZURE_SDK_REPO: azure-sdk-for-python
-        AZURE_SDK_PARAMS: ''
-      go:
-        AZURE_SDK_REPO: azure-sdk-for-go
-        AZURE_SDK_PARAMS: '-o latest'
-  pool:
-    vmImage: 'Ubuntu 16.04'
-  variables:
-    NODE_OPTIONS: '--max-old-space-size=8192'
-  steps:
-  - script: echo $(NODE_OPTIONS)
-  - script: "scripts/swagger-to-sdk.sh Azure/$(AZURE_SDK_REPO) -v $(AZURE_SDK_PARAMS)"
-    displayName: "Swagger to SDK script"