Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved AdditionalCapabilities out from VM profile to VMSS and updated SKUs API to support zonal capabilities #5753

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Moved AdditionalCapabilities out from VM profile to VMSS and updated SKUs API to support zonal capabilities #5753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad369e6
Updated comments and introduced AvailabilitySetSkuType to help users …
robhat1 Sep 20, 2018
bfa09c3
Merge remote-tracking branch 'upstream/master'
robhat1 Apr 24, 2019
1f5174c
Moved AdditionalCapabilities out from VM profile to VMSS and updated …
robhat1 Apr 24, 2019
cadde18
Fixed indentation
robhat1 Apr 24, 2019
0023ab8
Fixed indentation in skus.json
robhat1 Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions specification/compute/resource-manager/Microsoft.Compute/stable/2019-03-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7649,10 +7649,6 @@
"$ref": "#/definitions/VirtualMachineScaleSetStorageProfile",
"description": "Specifies the storage settings for the virtual machine disks."
},
"additionalCapabilities": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for a stable version, why is this needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property was there for a feature in private preview and based on discussion between the dev team/PM teams from compute and storage + folks from SDK, there was an agreement that we want to change this to provide better user experience from API stand-point.

Copy link
Contributor

@dsgouda dsgouda Apr 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, but this is a change to a stable version which has already been published, something that is not allowed. Was this approved by ARM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we already published powershell/CLIs and other tools based on this API-version? My understanding was that it is still not done and our team is still pushing changes for this new api-version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed offline that this version has not been released in SDKs, this is good to go

"$ref": "#/definitions/AdditionalCapabilities",
"description": "Specifies additional capabilities enabled or disabled on the virtual machine in the scale set. For instance: whether the virtual machine has the capability to support attaching managed data disks with UltraSSD_LRS storage account type."
},
"networkProfile": {
"$ref": "#/definitions/VirtualMachineScaleSetNetworkProfile",
"description": "Specifies properties of the network interfaces of the virtual machines in the scale set."
Expand Down Expand Up @@ -7769,6 +7765,10 @@
"proximityPlacementGroup": {
"$ref": "#/definitions/SubResource",
"description": "Specifies information about the proximity placement group that the virtual machine scale set should be assigned to. <br><br>Minimum api-version: 2018-04-01."
},
"additionalCapabilities": {
"$ref": "#/definitions/AdditionalCapabilities",
"description": "Specifies additional capabilities enabled or disabled on the Virtual Machines in the Virtual Machine Scale Set. For instance: whether the Virtual Machines have the capability to support attaching managed data disks with UltraSSD_LRS storage account type."
}
},
"description": "Describes the properties of a Virtual Machine Scale Set."
Expand All @@ -7790,6 +7790,10 @@
"singlePlacementGroup": {
"type": "boolean",
"description": "When true this limits the scale set to a single placement group, of max size 100 virtual machines."
},
"additionalCapabilities": {
"$ref": "#/definitions/AdditionalCapabilities",
"description": "Specifies additional capabilities enabled or disabled on the Virtual Machines in the Virtual Machine Scale Set. For instance: whether the Virtual Machines have the capability to support attaching managed data disks with UltraSSD_LRS storage account type."
}
},
"description": "Describes the properties of a Virtual Machine Scale Set."
Expand Down
Loading