Add deployment APIs for Microsoft.Resources #5737

Tiano2017 · 2019-04-23T01:29:04Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-04-23T01:29:49Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-04-23T01:30:48Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5555

AutorestCI · 2019-04-23T01:33:31Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4914

nschonni

The Suggestions will probably look off unless you look at them on the file tab. It's just some camelCase stuff

nschonni · 2019-04-23T01:47:48Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "x-ms-skip-url-encoding": true
+          },
+          {
+


Suggested change

"tagName": {

gave it a try, but this seems to be a breaking change... I'm not sure if we can change it.

nschonni · 2019-04-23T01:48:05Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "x-ms-skip-url-encoding": true
+          },
+          {
+


Suggested change

"tagValue": {

azuresdkci · 2019-04-23T01:56:27Z

Can one of the admins verify this patch?

AutorestCI · 2019-04-23T02:06:32Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#3306

REST Spec PR 'Azure/azure-rest-api-specs#5737' REST Spec PR Author 'Tiano2017' REST Spec PR Last commit

adxsdknet · 2019-04-23T02:34:49Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5906
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@1c95204

AutorestCI · 2019-04-23T03:00:25Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8fwf786y/rest/specification/resources/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpvtix_ecy']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

majastrz · 2019-04-23T19:26:12Z

  "name": "groupId",

This should be called managementGroupId to make it obvious. #Closed

Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json:3884 in 561b51c. [](commit_id = 561b51c, deletion_comment = False)

majastrz · 2019-04-23T19:26:29Z

  "description": "The name of the deployment to delete.",

The description doesn't match what this is. #Closed

Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json:3888 in 561b51c. [](commit_id = 561b51c, deletion_comment = False)

majastrz · 2019-04-23T19:29:13Z

},

I wonder if we should refactor this into a parameter we reference like the others. If you agree to do it, we probably should only do it in 2019-05-01. #Closed

Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json:117 in 561b51c. [](commit_id = 561b51c, deletion_comment = False)

TianoMS · 2019-04-23T19:31:06Z

  "name": "groupId",

I was referring to what MG group team did for their APIs. They use "groupId" for this parameter..

In reply to: 485941229 [](ancestors = 485941229)

Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json:3884 in dff86dc. [](commit_id = dff86dc, deletion_comment = False)

TianoMS · 2019-04-23T19:31:22Z

  "description": "The name of the deployment to delete.",

will fix this one.

In reply to: 485941319 [](ancestors = 485941319)

Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json:3888 in dff86dc. [](commit_id = dff86dc, deletion_comment = False)

majastrz · 2019-04-23T19:34:07Z

@Tiano2017, the PutDeploymentAtManagementGroup.json file appears to be empty. And you've also got some checks failing right now. #Closed

majastrz · 2019-04-23T19:34:47Z

  "name": "groupId",

ok

In reply to: 485942694 [](ancestors = 485942694,485941229)

Refers to: specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json:3884 in 561b51c. [](commit_id = 561b51c, deletion_comment = False)

shahabhijeet · 2019-04-30T15:54:10Z

@Tiano2017 does this PR has the new operation that we discussed offline?
Is this ready to be reviewed?

Tiano2017 · 2019-04-30T19:42:10Z

@Tiano2017 does this PR has the new operation that we discussed offline?
Is this ready to be reviewed?

Not yet.. Let me close on that and will let you know once it's ready for review.

shahabhijeet · 2019-05-21T19:23:09Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

@@ -59,6 +59,321 @@
        }
      }
    },
+    "/providers/Microsoft.Management/managementGroups/{groupId}/providers/Microsoft.Resources/deployments/{deploymentName}": {


@Tiano2017 let's make the parameter token consistent across all operations
let's make it managementGroupId as mentioned on line 215

sure. actually we want "groupId" as the parameter name, but I'll make it consistent in the file.

shahabhijeet · 2019-05-21T19:25:41Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "The resource t


@Tiano2017 make this managementGroupId in order to be consistent with the parameter being used in operation paths.

will make everywhere "groupId".

shahabhijeet · 2019-05-21T19:26:26Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "The resource t


nit: can you make the description as Name of the deployement, remove leading "the"

I'll leave it. BTW, you can do a compare with my first iteration to see what I changed. Basically the first iteration was copied from the previous version.

shahabhijeet · 2019-05-21T19:26:55Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "The resource t


nit: can you make the description as "target subscription Id" instead of leading with "The"

will leave them since it's copied from the previous version.

shahabhijeet · 2019-05-21T19:27:26Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "The resource t


nit: remove leading "the"

shahabhijeet · 2019-05-21T19:28:48Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "The resource t


nit: Get Deployment Operation Id

shahabhijeet · 2019-05-21T19:44:03Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-05-01/resources.json

+            "in": "path",
+            "required": true,
+            "type": "string",
+            "description": "The name of the deployment.",


nit: name of the deployment

sergey-shandar · 2019-05-22T23:43:31Z

specification/resources/resource-manager/Microsoft.Resources/stable/2019-03-01/resources.json

@@ -2,7 +2,7 @@
  "swagger": "2.0",
  "info": {
    "title": "ResourceManagementClient",
-    "version": "2018-05-01",


So we had this API version? That's bad. I assume, now we may have some SDK breaking changes.

we haven't released any package with this swagger, so I think it's still fine.

@Tiano2017 as far as I know, if the spec was merged to master, some SDK packages could be released.

Not sure what's the right approach here. This change is more like fixing a bug, and I assume it's only going to impact future versions of packages. can we assume it's safe in that case?

# Conflicts: # specification/resources/resource-manager/readme.md

sergey-shandar · 2019-05-28T20:25:12Z

@shahabhijeet could you have a look one more time.

shahabhijeet · 2019-05-29T21:25:54Z

@Tiano2017 lost entire context :), will sync with @sergey-shandar and will get back on this PR by EOD today.

Tiano2017 added 3 commits April 22, 2019 23:56

copy from 2019-03-01.

561b51c

Add changes for management group deployment.

53ffdba

add changes in readme.md.

dff86dc

AutorestCI mentioned this pull request Apr 23, 2019

[AutoPR resources/resource-manager] Tiano mg deployment Azure/azure-sdk-for-python#4937

Closed

Tiano2017 changed the title ~~Tiano mg deployment~~ Add deployment APIs for Microsoft.Resources Apr 23, 2019

AutorestCI mentioned this pull request Apr 23, 2019

[AutoPR resources/resource-manager] Tiano mg deployment Azure/azure-sdk-for-go#4624

Closed

nschonni reviewed Apr 23, 2019

View reviewed changes

azuresdkci assigned shahabhijeet Apr 23, 2019

azuresdkci requested a review from shahabhijeet April 23, 2019 02:02

AutorestCI mentioned this pull request Apr 23, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#2418

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 23, 2019

.NET SDK Resource Provider:'Resource'

1c95204

REST Spec PR 'Azure/azure-rest-api-specs#5737' REST Spec PR Author 'Tiano2017' REST Spec PR Last commit

majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 23, 2019

majastrz self-assigned this Apr 23, 2019

majastrz self-requested a review April 23, 2019 19:36

majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 26, 2019

shahabhijeet requested changes May 21, 2019

View reviewed changes

more changes.

3861ead

This was referenced May 22, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3104

Closed

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-java#3738

Closed

revert the tagname and tagvalue change.

2327cba

AutorestCI mentioned this pull request May 22, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3131

Closed

sergey-shandar reviewed May 22, 2019

View reviewed changes

reference exmple file.

acbe276

AutorestCI mentioned this pull request May 22, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3140

Closed

update example file.

8dcf9c3

AutorestCI mentioned this pull request May 23, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3141

Closed

fixes

56031e9

This was referenced May 23, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3164

Closed

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-python#5457

Closed

Merge remote-tracking branch 'origin/master' into tiano-mg-deployment

7829634

# Conflicts: # specification/resources/resource-manager/readme.md

AutorestCI mentioned this pull request May 24, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3183

Closed

shahabhijeet approved these changes May 29, 2019

View reviewed changes

Add descriptions.

621a104

Tiano2017 requested a review from stankovski as a code owner May 29, 2019 23:17

sergey-shandar approved these changes May 30, 2019

View reviewed changes

sergey-shandar merged commit 97aede4 into Azure:master May 30, 2019

AutorestCI mentioned this pull request May 30, 2019

[AutoPR resources/resource-manager] Add deployment APIs for Microsoft.Resources Azure/azure-sdk-for-js#3305

Merged

Add deployment APIs for Microsoft.Resources #5737

Add deployment APIs for Microsoft.Resources #5737

Conversation

Tiano2017 commented Apr 23, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Apr 23, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 23, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 23, 2019 • edited Loading

Automation for azure-sdk-for-go

nschonni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azuresdkci commented Apr 23, 2019

AutorestCI commented Apr 23, 2019 • edited Loading

Automation for azure-sdk-for-js

adxsdknet commented Apr 23, 2019

Automation for azure-sdk-for-net

AutorestCI commented Apr 23, 2019 • edited Loading

Automation for azure-sdk-for-java

majastrz commented Apr 23, 2019 • edited Loading

majastrz commented Apr 23, 2019 • edited Loading

majastrz commented Apr 23, 2019 • edited Loading

TianoMS commented Apr 23, 2019

TianoMS commented Apr 23, 2019

majastrz commented Apr 23, 2019 • edited Loading

majastrz commented Apr 23, 2019

shahabhijeet commented Apr 30, 2019

Tiano2017 commented Apr 30, 2019

Choose a reason for hiding this comment

Tiano2017 May 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergey-shandar commented May 28, 2019

shahabhijeet commented May 29, 2019

Tiano2017 commented Apr 23, 2019 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading

AutorestCI commented Apr 23, 2019 •

edited

Loading

majastrz commented Apr 23, 2019 •

edited

Loading

majastrz commented Apr 23, 2019 •

edited

Loading

majastrz commented Apr 23, 2019 •

edited

Loading

majastrz commented Apr 23, 2019 •

edited

Loading

Tiano2017 May 22, 2019 •

edited

Loading