Added data connection check name availability operation #5648

liatbezalel · 2019-04-15T15:19:19Z

Added data connection check name availability operation as part of swagger operations completeness.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-04-15T15:19:55Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-04-15T15:20:16Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmpu3rf65yn/rest/specification/azure-kusto/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpg5n9biak']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

REST Spec PR 'Azure/azure-rest-api-specs#5648' REST Spec PR Author 'liatbezalel' REST Spec PR Last commit

adxsdknet · 2019-04-15T15:26:04Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5798
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@8404cd0
adxsdknet/azure-sdk-for-net@fa7559a

azuresdkci · 2019-04-15T15:27:45Z

Can one of the admins verify this patch?

AutorestCI · 2019-04-15T15:31:08Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4642

AutorestCI · 2019-04-15T16:04:05Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4759

praries880 · 2019-04-15T22:17:17Z

@liatbezalel kindly take care of the merge conflicts

AutorestCI · 2019-04-16T09:17:14Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3168

ryansbenson · 2019-04-16T21:35:44Z

specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2019-01-21/kusto.json

@@ -2031,6 +2110,32 @@
        }
      }
    },
+	"CheckNameAvailabilityResult": {


This should align with the following:

{
"nameAvailable": true|false,
"reason": "Invalid|AlreadyExists",
"message": ""
}

https://github.com/Azure/azure-resource-manager-rpc/blob/002d272ec9c522f1b8606c5b062a9fa80145efe8/v1.0/proxy-api-reference.md#check-name-availability-requests

Is this already GA'd in this form?

Yes, it's already in production and unfortunately this might be a breaking change. Can we please keep it in that way?

The reason we used enum instead of boolean for "nameAvailable" is because of the linter warning:

WARNING (EnumInsteadOfBoolean/R3018/ARMViolation): Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined.

What should be the correct behavior in that case?

I feel the same way about the bool here but its the pattern for checkNameAvailability. If this is already out in a GA'd api version then we can move forward with just documenting the behavior, even if its not perfectly aligned. Consider aligning in a future api version though.

It's already GA'd, so we'll note it and keep that in mind for the next api version

...er/Microsoft.Kusto/stable/2019-01-21/examples/KustoDataConnectionsCheckNameAvailability.json

…ub.com/liatbezalel/azure-rest-api-specs into addDataConnectionCheckNameAvailability

…l validation).

ryansbenson · 2019-04-19T19:10:13Z

specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2019-01-21/kusto.json

@@ -2031,6 +2110,32 @@
        }
      }
    },
+	"CheckNameAvailabilityResult": {


I feel the same way about the bool here but its the pattern for checkNameAvailability. If this is already out in a GA'd api version then we can move forward with just documenting the behavior, even if its not perfectly aligned. Consider aligning in a future api version though.

...source-manager/Microsoft.Kusto/stable/2019-01-21/examples/KustoDataConnectionValidation.json

praries880 · 2019-04-29T14:11:42Z

@RyanBensonMSFT did the latest changes take care of your requested changes?

liatbezalel · 2019-04-29T14:15:15Z

@praries880 @RyanBensonMSFT after discussion we decided to change the structure of the ckuck name availability as @RyanBensonMSFT suggested.
We'll add a new iteration for that

REST Spec PR 'Azure/azure-rest-api-specs#5648' REST Spec PR Author 'liatbezalel' REST Spec PR Last commit

liatbezalel · 2019-05-06T14:45:26Z

@RyanBensonMSFT we are now aligned with the check name pattern. Can you please review the latest changes?

majastrz

Looks good to me.

* .NET SDK Resource Provider:'Kusto' REST Spec PR 'Azure/azure-rest-api-specs#5648' REST Spec PR Author 'liatbezalel' REST Spec PR Last commit * .NET SDK Resource Provider:'Kusto' REST Spec PR 'Azure/azure-rest-api-specs#5648' REST Spec PR Author 'liatbezalel' REST Spec PR Last commit

Added data connection check name availability operation

ce29ef3

azuresdkci assigned praries880 Apr 15, 2019

azuresdkci requested a review from praries880 April 15, 2019 15:20

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 15, 2019

.NET SDK Resource Provider:'Kusto'

8404cd0

REST Spec PR 'Azure/azure-rest-api-specs#5648' REST Spec PR Author 'liatbezalel' REST Spec PR Last commit

AutorestCI mentioned this pull request Apr 15, 2019

[AutoPR azure-kusto/resource-manager] Added data connection check name availability operation Azure/azure-sdk-for-python#4850

Merged

AutorestCI mentioned this pull request Apr 15, 2019

[AutoPR azure-kusto/resource-manager] Added data connection check name availability operation Azure/azure-sdk-for-go#4545

Closed

praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 15, 2019

Merge branch 'master' into addDataConnectionCheckNameAvailability

0c6b2cb

AutorestCI mentioned this pull request Apr 16, 2019

[AutoPR azure-kusto/resource-manager] Added data connection check name availability operation Azure/azure-sdk-for-java#3386

Merged

ryansbenson reviewed Apr 16, 2019

View reviewed changes

libezale added 7 commits April 17, 2019 11:01

Fixed KustoDataConnectionsCheckNameAvailability example

592d412

Merge branch 'addDataConnectionCheckNameAvailability' of https://gith…

924735b

…ub.com/liatbezalel/azure-rest-api-specs into addDataConnectionCheckNameAvailability

fixed example

e91ac72

Removed special character

3d40274

fixed examples (not related to the new operation, but failed the mode…

f677349

…l validation).

More of other examples fixes

75f4a0c

fixed spaces

7f8bd3c

ryansbenson reviewed Apr 19, 2019

View reviewed changes

ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 19, 2019

Adding property to the data connection validation example

5543d41

Fixed example

536c15e

AutorestCI mentioned this pull request Apr 29, 2019

[AutoPR azure-kusto/resource-manager] Added data connection check name availability operation Azure/azure-sdk-for-go#4693

Merged

Aligned with ARM check name availability pattern

4ca4acf

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 6, 2019

.NET SDK Resource Provider:'Kusto'

fa7559a

REST Spec PR 'Azure/azure-rest-api-specs#5648' REST Spec PR Author 'liatbezalel' REST Spec PR Last commit

majastrz approved these changes May 6, 2019

View reviewed changes

praries880 approved these changes May 7, 2019

View reviewed changes

praries880 merged commit 1b90713 into Azure:master May 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added data connection check name availability operation #5648

Added data connection check name availability operation #5648

liatbezalel commented Apr 15, 2019

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

adxsdknet commented Apr 15, 2019 •

edited

Loading

azuresdkci commented Apr 15, 2019

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

praries880 commented Apr 15, 2019

AutorestCI commented Apr 16, 2019 •

edited

Loading

ryansbenson Apr 16, 2019

liatbezalel Apr 17, 2019

ryansbenson Apr 19, 2019

liatbezalel Apr 23, 2019

ryansbenson Apr 19, 2019

praries880 commented Apr 29, 2019

liatbezalel commented Apr 29, 2019

liatbezalel commented May 6, 2019

majastrz left a comment

Added data connection check name availability operation #5648

Added data connection check name availability operation #5648

Conversation

liatbezalel commented Apr 15, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-ruby

adxsdknet commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-net

azuresdkci commented Apr 15, 2019

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-go

praries880 commented Apr 15, 2019

AutorestCI commented Apr 16, 2019 • edited Loading

Automation for azure-sdk-for-java

ryansbenson Apr 16, 2019

Choose a reason for hiding this comment

liatbezalel Apr 17, 2019

Choose a reason for hiding this comment

ryansbenson Apr 19, 2019

Choose a reason for hiding this comment

liatbezalel Apr 23, 2019

Choose a reason for hiding this comment

ryansbenson Apr 19, 2019

Choose a reason for hiding this comment

praries880 commented Apr 29, 2019

liatbezalel commented Apr 29, 2019

liatbezalel commented May 6, 2019

majastrz left a comment

Choose a reason for hiding this comment

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

adxsdknet commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 16, 2019 •

edited

Loading