Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing host information to alerts management #5580

Merged
merged 1 commit into from
Apr 8, 2019
Merged

add missing host information to alerts management #5580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ource-manager/Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"title": "Azure Alerts Management Service Resource Provider",
"description": "REST APIs for Azure Alerts Management Service."
},
"host": "management.azure.com",
"schemes": [
"https"
],
Expand Down
1 change: 1 addition & 0 deletions ...anager/Microsoft.AlertsManagement/preview/2018-11-02-privatepreview/AlertsManagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"title": "Azure Alerts Management Service Resource Provider",
"description": "REST APIs for Azure Alerts Management Service."
},
"host": "management.azure.com",
"schemes": [
"https"
],
Expand Down
1 change: 1 addition & 0 deletions ...ource-manager/Microsoft.AlertsManagement/preview/2019-03-01-preview/AlertsManagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"title": "Azure Alerts Management Service Resource Provider",
"description": "Azure Alerts Management Service provides a single pane of glass of alerts across Azure Monitor."
},
"host": "management.azure.com",
"schemes": [
"https"
],
Expand Down
1 change: 1 addition & 0 deletions ...ement/resource-manager/Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"title": "Azure Alerts Management Service Resource Provider",
"description": "Azure Alerts Management Service provides a single pane of glass of alerts across Azure Monitor."
},
"host": "management.azure.com",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah host is not strictly required in the swagger def, but I tink we can treat is as it should be in hte semantic validator, open a bug ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes was thinking the same thing. Open in https://github.com/azure/oav?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened Azure/oav#413

"schemes": [
"https"
],
Expand Down