Luis swagger fixes #5416

diberry · 2019-03-18T17:33:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-03-18T17:34:28Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4327

AutorestCI · 2019-03-18T17:34:34Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1642

AutorestCI · 2019-03-18T17:34:34Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#4389

AutorestCI · 2019-03-18T17:34:47Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-03-18T17:34:58Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-03-18T17:35:04Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

azuresdkci · 2019-03-18T17:35:31Z

Can one of the admins verify this patch?

nschonni · 2019-03-18T19:25:48Z

specification/cognitiveservices/data-plane/LUIS/Authoring/stable/v2.0/LUIS-Authoring.json

@@ -2605,7 +2648,7 @@
    },
    "/apps/{appId}/querylogs": {
      "get": {
-        "description": "Gets the query logs of the past month for the application.",
+        "description": "Gets thelogs of the past month's endpoint queries for the application.",


thelogs -> the logs

specification/cognitiveservices/data-plane/LUIS/Authoring/stable/v2.0/LUIS-Authoring.json

nschonni · 2019-03-18T19:26:51Z

specification/cognitiveservices/data-plane/LUIS/Authoring/stable/v2.0/LUIS-Authoring.json

@@ -9214,7 +9263,7 @@
          "description": "A list of comma-separated values."
        },
        "isExchangeable": {
-          "description": "An exchangeable phrase list feature are serves as single feature to the LUIS underlying training algorithm. It is used as a lexicon lookup feature where its value is 1 if the lexicon contains a given word or 0 if it doesn’t. Think of an exchangeable as a synonyms list. A non-exchangeable phrase list feature has all the phrases in the list serve as separate features to the underlying training algorithm. So, if you your phrase list feature contains 5 phrases, they will be mapped to 5 separate features. You can think of the non-exchangeable phrase list feature as an additional bag of words that you are willing to add to LUIS existing vocabulary features. Think of a non-exchangeable as set of different words. Default value is true.",
+          "description": "An exchangeable phrase list feature are serves as single feature to the LUIS underlying training algorithm. It is used as a lexicon lookup feature where its value is 1 if the lexicon contains a given word or 0 if it doesn’t. Think of an exchangeable as a synonyms list. A non-exchangeable phrase list feature has all the phrases in the list serve as separate features to the underlying training algorithm. So, if you your phrase list feature contains 5 phrases, they will be mapped to 5 separate features. You can think of the non-exchangeable phrase list feature as an additional bag of words that you are willing to add to LUIS existing vocabulary features. Think of a non-exchangeable as set of different words. Default value is true.",,


Double comma at the end

@nschonni what tool did you use to find these issues?

Opening the content in VS Code caught the double comma at the end as an error. I've got an running PR to add a cSpell dictionary with #4836. Right now, I just open that branch and past the code into an existing file to see the issues though.

jhendrixMSFT · 2019-03-19T17:22:13Z

Please note this contains breaking changes in a swagger marked as stable which is discouraged.

shahabhijeet · 2019-03-19T17:45:11Z

@jhendrixMSFT .NET SDK does not support multiple RPs as of now.
I think we should have two separate PRs for each RP.
If one SDK generation fails and other succeeds, it's challenging to let the user know what exactly failed as there are only 1 job created for 1 RP.
But if you still would like to merge, go ahead, .NET SDK has still not enabled multiple RPs.
Plus this is data plane SDK

diberry · 2019-03-19T17:49:17Z

@jhendrixMSFT @shahabhijeet @cahann @nebadr

This PR has changes from the service team, provided by @nebadr and changes to the descriptions I provided as docs member.

I'll remove the runtime changes so it is only 1 file being changed.

Are there specific issues about the service team's changes that you need addressed?

diberry · 2019-03-19T17:59:53Z

Runtime broken out into different PR #5424

REST Spec PR 'Azure/azure-rest-api-specs#5416' REST Spec PR Author 'diberry' REST Spec PR Last commit

adxsdknet · 2019-03-19T18:06:54Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5511
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@39f8c63

jhendrixMSFT · 2019-03-19T18:43:46Z

@AutorestCI regenerate azure-sdk-for-go

REST Spec PR 'Azure/azure-rest-api-specs#5416' REST Spec PR Author 'diberry' REST Spec PR Last commit

Nesma and others added 3 commits March 13, 2019 18:25

Swagger fixes

4c6a08e

Error fix

2277972

edits to descriptions

d64fd0b

diberry requested review from DavidLiCIG and yangyuan as code owners March 18, 2019 17:33

azuresdkci assigned jhendrixMSFT Mar 18, 2019

azuresdkci requested a review from jhendrixMSFT March 18, 2019 17:35

nschonni reviewed Mar 18, 2019

View reviewed changes

per nschonni

40cc597

fix interchangeable

b1a2198

jhendrixMSFT added the potential-sdk-breaking-change label Mar 19, 2019

removing runtime swagger - in different PR

fab65b7

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR cognitiveservices/data-plane/LUIS/Authoring] Luis swagger fixes Azure/azure-sdk-for-python#4612

Closed

diberry mentioned this pull request Mar 19, 2019

LUIS runtime changes #5424

Merged

5 tasks

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 19, 2019

.NET SDK Resource Provider:'Authoring'

39f8c63

REST Spec PR 'Azure/azure-rest-api-specs#5416' REST Spec PR Author 'diberry' REST Spec PR Last commit

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR cognitiveservices/data-plane/LUIS/Authoring] Luis swagger fixes Azure/azure-sdk-for-go#4323

Merged

jhendrixMSFT approved these changes Mar 19, 2019

View reviewed changes

jhendrixMSFT merged commit 4cd8984 into Azure:master Mar 19, 2019

AutorestCI mentioned this pull request Mar 19, 2019

[AutoPR cognitiveservices/data-plane/LUIS/Authoring] Luis swagger fixes Azure/azure-sdk-for-js#1641

Merged

dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 21, 2019

.NET SDK Resource Provider:'Authoring' (#5511)

b0c2eaa

REST Spec PR 'Azure/azure-rest-api-specs#5416' REST Spec PR Author 'diberry' REST Spec PR Last commit

dsgouda mentioned this pull request Mar 26, 2019

Revert some changes in authoring #5447

Merged

5 tasks

mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019

.NET SDK Resource Provider:'Authoring' (Azure#5511)

a5f4b4c

REST Spec PR 'Azure/azure-rest-api-specs#5416' REST Spec PR Author 'diberry' REST Spec PR Last commit

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Luis swagger fixes #5416

Luis swagger fixes #5416

diberry commented Mar 18, 2019

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

azuresdkci commented Mar 18, 2019

nschonni Mar 18, 2019

nschonni Mar 18, 2019

diberry Mar 18, 2019

nschonni Mar 18, 2019

jhendrixMSFT commented Mar 19, 2019

shahabhijeet commented Mar 19, 2019

diberry commented Mar 19, 2019

diberry commented Mar 19, 2019

adxsdknet commented Mar 19, 2019

jhendrixMSFT commented Mar 19, 2019

Luis swagger fixes #5416

Luis swagger fixes #5416

Conversation

diberry commented Mar 18, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Mar 18, 2019 • edited Loading

Automation for azure-sdk-for-node

azuresdkci commented Mar 18, 2019

nschonni Mar 18, 2019

Choose a reason for hiding this comment

nschonni Mar 18, 2019

Choose a reason for hiding this comment

diberry Mar 18, 2019

Choose a reason for hiding this comment

nschonni Mar 18, 2019

Choose a reason for hiding this comment

jhendrixMSFT commented Mar 19, 2019

shahabhijeet commented Mar 19, 2019

diberry commented Mar 19, 2019

diberry commented Mar 19, 2019

adxsdknet commented Mar 19, 2019

Automation for azure-sdk-for-net

jhendrixMSFT commented Mar 19, 2019

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading

AutorestCI commented Mar 18, 2019 •

edited

Loading