Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set typeproperties to be not required for some datasets #5382

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Set typeproperties to be not required for some datasets #5382

merged 1 commit into from
Mar 21, 2019

Conversation

Yiliu-microsoft
Copy link
Contributor

@Yiliu-microsoft Yiliu-microsoft commented Mar 14, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@msftclas
Copy link

msftclas commented Mar 14, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4381

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4344

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3084

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5005

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 14, 2019
@adxsdknet
.NET SDK Resource Provider:'DataFactory'
0489349 
REST Spec PR 'Azure/azure-rest-api-specs#5382'
REST Spec PR Author 'Yiliu-microsoft'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5443
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@0489349

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 14, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1691

@Yiliu-microsoft Yiliu-microsoft changed the title Update the public swagger by reference to private swagger Set typeproperties to be not required for some datasets Mar 15, 2019
anuchandy
anuchandy approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding 'SDK Breaking Change' tag since this PR changes a required property to optional. In languages like C#, this can change the order of parameter in the ctr (required args appear first followed by option, so typeProperties param will be moved).

@anuchandy anuchandy merged commit 5324dfc into Azure:master Mar 21, 2019
This was referenced Mar 21, 2019
Merged
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 21, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'DataFactory' (#5443)
e1e3060 
REST Spec PR 'Azure/azure-rest-api-specs#5382'
REST Spec PR Author 'Yiliu-microsoft'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'DataFactory' (Azure#5443)
c9ca5d6 
REST Spec PR 'Azure/azure-rest-api-specs#5382'
REST Spec PR Author 'Yiliu-microsoft'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yiliu-microsoft @msftclas @AutorestCI @azuresdkci @adxsdknet @anuchandy