Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Blueprint spec to include resource group tags #5263

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Updating Blueprint spec to include resource group tags #5263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .../resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/blueprintDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,9 +1205,21 @@
"type": "string",
"description": "Name of peer artifact."
}
},
"tags": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not a strict rule, this is best done in an incremented api version. If a user with an updated client populates this value, and then a user with a legacy client does a GET/MERGE/PUT to modify the resource, the property would be wiped out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a risk we were aware of but deemed the risk low enough to not require a version bump. If we weren't in preview we wouldn't take any such risk, even low, but in this case we see it as highly unlikely two users would be modifying the same blueprint with two separate SDK releases. If possible we'd like to push this one through to the existing version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

"description": "Tags to be assigned to this resource group.",
"$ref": "#/definitions/ResourceGroupTagCollection"
}
}
},
"ResourceGroupTagCollection": {
"description": "A dictionary of resource group tag values.",
"type": "object",
"properties": {},
"additionalProperties": {
"type": "string"
}
},
"ParameterDefinitionMetadata": {
"type": "object",
"description": "User-friendly properties for this parameter.",
Expand Down