Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 #5137

Merged
merged 5 commits into from
Mar 4, 2019
Merged

[Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 #5137

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bf8878
Add Hosting Environment network dependencies
dejo-msft Jan 31, 2019
b772c09
Address PR description feedback
derekj627 Feb 27, 2019
1ff1f6d
Add Network Dependencies examples
dejo-msft Feb 27, 2019
61d39f0
Fix casing
dejo-msft Mar 2, 2019
66114e5
Remove incorrect pagination from examples.
dejo-msft Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 172 additions & 2 deletions ...fication/web/resource-manager/Microsoft.Web/stable/2018-02-01/AppServiceEnvironments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,51 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/hostingEnvironments/{name}/inboundnetworkdependenciesendpoints": {
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"get": {
"tags": [
"AppServiceEnvironments"
],
"summary": "Get the network endpoints of all inbound dependencies of an ase.",
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"description": "Get the network endpoints of all inbound dependencies of an ase.",
"operationId": "AppServiceEnvironments_GetInboundNetworkDependenciesEndpoints",
"parameters": [
{
"$ref": "#/parameters/resourceGroupNameParameter"
},
{
"name": "name",
"in": "path",
"description": "Name of the App Service Environment.",
"required": true,
"type": "string"
},
{
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"type": "array",
"items": {
"$ref": "#/definitions/InboundEnvironmentEndpoint"
}
}
},
"default": {
"description": "App Service error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/hostingEnvironments/{name}/metricdefinitions": {
"get": {
"tags": [
Expand Down Expand Up @@ -1209,6 +1254,51 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/hostingEnvironments/{name}/outboundnetworkdependenciesendpoints": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not functionally impactful given case insensitivity in URIs, the resourceTypeNames should follow lowerCamelCase convention

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed these. Thanks!

"get": {
"tags": [
"AppServiceEnvironments"
],
"summary": "Get the network endpoints of all outbound dependencies of an ase.",
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"description": "Get the network endpoints of all outbound dependencies of an ase.",
"operationId": "AppServiceEnvironments_GetOutboundNetworkDependenciesEndpoints",
"parameters": [
{
"$ref": "#/parameters/resourceGroupNameParameter"
},
{
"name": "name",
"in": "path",
"description": "Name of the App Service Environment.",
"required": true,
"type": "string"
},
{
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"type": "array",
"items": {
"$ref": "#/definitions/OutboundEnvironmentEndpoint"
}
}
},
"default": {
"description": "App Service error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Web/hostingEnvironments/{name}/reboot": {
"post": {
"tags": [
Expand Down Expand Up @@ -2132,7 +2222,7 @@
}
},
"AppServiceEnvironmentPatchResource": {
"description": "ARM resource for a app service environment.",
"description": "ARM resource for a app service enviroment.",
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -2163,6 +2253,45 @@
}
}
},
"EndpointDependency": {
"type": "object",
"properties": {
"domainName": {
"description": "The Domain Name of the dependency.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - inconsistent casing of "Domain Name" in the EndpointDependency description vs domainName property description

"type": "string"
},
"endpointDetails": {
"description": "The IP Addresses and Ports used when connecting to DomainName.",
"type": "array",
"items": {
"$ref": "#/definitions/EndpointDetail"
}
}
}
},
"EndpointDetail": {
"type": "object",
"properties": {
"ipAddress": {
"description": "An IP Address that Domain Name currently resolves to.",
"type": "string"
},
"port": {
"format": "int32",
"description": "The port an endpoint is connected to.",
"type": "integer"
},
"latency": {
"format": "double",
"description": "The time in milliseconds it takes to connect to this IpAddress at this Port.",
"type": "number"
},
"isAccessable": {
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"description": "Whether it is possible to connect to IpAddress.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Whether you are able to make an inbound TCP connection to the ipAddress + port? From where?

"type": "boolean"
}
}
},
"HostingEnvironmentDiagnostics": {
"description": "Diagnostics for an App Service Environment.",
"type": "object",
Expand All @@ -2177,6 +2306,30 @@
}
}
},
"InboundEnvironmentEndpoint": {
"description": "Endpoints for a particular type",
"type": "object",
"properties": {
"description": {
"description": "Text describing the endpoints.",
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"type": "string"
},
"endpoints": {
"description": "The endpoint ip addresses in cidr notation.",
"type": "array",
"items": {
"type": "string"
}
},
"ports": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that endpoints and ports are separate arrays, how does this work in practice? Each endpoint IP address supports each port?

"description": "The ports",
"type": "array",
"items": {
"type": "string"
}
}
}
},
"MetricAvailabilily": {
"description": "Metric availability and retention.",
"type": "object",
Expand Down Expand Up @@ -2231,6 +2384,23 @@
}
}
},
"OutboundEnvironmentEndpoint": {
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"description": "Endpoints of a common type.",
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"type": "object",
"properties": {
"category": {
"description": "Short description of the endpoints.",
praries880 marked this conversation as resolved.
Show resolved Hide resolved
"type": "string"
},
"endpoints": {
"description": "The endpoint's domain name and the IP Addresses it currently resolves to.",
"type": "array",
"items": {
"$ref": "#/definitions/EndpointDependency"
}
}
}
},
"SkuInfo": {
"description": "SKU discovery information.",
"type": "object",
Expand Down Expand Up @@ -2467,4 +2637,4 @@
]
}
]
}
}