Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription #5105

v-Ajnava · 2019-01-28T19:09:00Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-portal-comment · 2019-01-28T19:09:02Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2019-01-28T19:09:34Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#579

AutorestCI · 2019-01-28T19:09:38Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2196

AutorestCI · 2019-01-28T19:09:40Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3873

AutorestCI · 2019-01-28T19:09:47Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3985

AutorestCI · 2019-01-28T19:10:38Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4191

AutorestCI · 2019-01-28T19:12:12Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2153

azuresdkci · 2019-01-28T19:19:17Z

Can one of the admins verify this patch?

jianghaolu · 2019-01-28T20:28:42Z

specification/eventhub/resource-manager/Microsoft.EventHub/stable/2017-04-01/EventHub.json

@@ -2250,6 +2250,10 @@
        "destination": {
          "$ref": "#/definitions/Destination",
          "description": "Properties of Destination where capture will be stored. (Storage Account, Blob Names)"
+        },
+		"skipEmptyArchives": {


Fix indentation please.

v-Ajnava · 2019-01-30T21:13:52Z

@jianghaolu I have fixed the indentation, can you please review ?

…ion (Azure#5105)" This reverts commit eaf5e5c.

* Revert "typo: azure-mgmt-containerservices -> azure-mgmt-containerservice (#5103)" This reverts commit c8be36b. * Revert "Add missing Java code gen info to Kusto (#5142)" This reverts commit 8c304e7. * Revert "Update compute.json (#4866)" This reverts commit 72afb64. * Revert "Add SkillsetOperations to C# code generation settings (#5132)" This reverts commit b2ed47f. * Revert "[GuestConfiguration]Update ConfigurationInfo class to include version field (#5131)" This reverts commit 930987c. * Revert "Adding new api-version to Microsoft.Security Alerts resource (#4902)" This reverts commit 93f46f5. * Revert "Add a spec for policyStates API version 2018-07-01-preview (#5134)" This reverts commit 84d025e. * Revert "added link to disk properties for UltraSSD values (#5135)" This reverts commit e713e24. * Revert "Undoing unintended removal of a field (#5133)" This reverts commit e0f2f8c. * Revert "Run separate instance of OAV (#5026)" This reverts commit e44239a. * Revert "Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription (#5105)" This reverts commit eaf5e5c. * Revert "Resourcehealth events response (#5116)" This reverts commit 935baac. * Revert "Add Helm Events to ACR Schema for Event Grid (#5109)" This reverts commit 6f4cee5. * Revert " Creates the "real" API for Scheduled Alert Rules (#5084)" This reverts commit d847550. * Revert "Update managedInstances.json (#5114)" This reverts commit 2072ba5. * Revert "HDFS FE: Update 2018-11-09 DataLakeStorage Swagger. (#5108)" This reverts commit 60a8c18. * Revert "Add dispatch child to LUIS Runtime response (#5100)" This reverts commit 03581da. * Revert "Add new field 'proximityPlacementGroup' to properties of HanaInstance (#5107)" This reverts commit 31fa6a1. * Revert "fix Go SDK codegen for Microsoft.Insights (#5106)" This reverts commit b5ac8e3. * Revert "[AKS] add apiServerAuthorizedIPRanges property (#5101)" This reverts commit 8d178c3.

…re#5105) * Added skipEmptyArchives to Eventhub CaptureDescription * updated formating * fixed indentation.

Added skipEmptyArchives to Eventhub CaptureDescription

00b488b

updated formating

a5bc337

azuresdkci assigned jianghaolu Jan 28, 2019

azuresdkci requested a review from jianghaolu January 28, 2019 19:09

AutorestCI mentioned this pull request Jan 28, 2019

[AutoPR eventhub/resource-manager] Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription Azure/azure-sdk-for-ruby#2185

Merged

jianghaolu reviewed Jan 28, 2019

View reviewed changes

fixed indentation.

b7d1b92

AutorestCI mentioned this pull request Jan 29, 2019

[AutoPR eventhub/resource-manager] Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription Azure/azure-sdk-for-node#4598

Merged

jianghaolu approved these changes Jan 31, 2019

View reviewed changes

jianghaolu merged commit eaf5e5c into Azure:master Jan 31, 2019

v-Ajnava mentioned this pull request Feb 1, 2019

Event Hub: added new Boolean property SkipEmptyArchives to Event Hub Capture Azure/azure-sdk-for-net#5200

Merged

9 tasks

yangl900 added a commit to yangl900/azure-rest-api-specs that referenced this pull request Feb 4, 2019

Revert "Eventhub: Added skipEmptyArchives to Eventhub CaptureDescript…

2a76f71

…ion (Azure#5105)" This reverts commit eaf5e5c.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription #5105

Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription #5105

v-Ajnava commented Jan 28, 2019

openapi-portal-comment bot commented Jan 28, 2019

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

azuresdkci commented Jan 28, 2019

jianghaolu Jan 28, 2019

v-Ajnava Jan 29, 2019

v-Ajnava commented Jan 30, 2019

Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription #5105

Eventhub: Added skipEmptyArchives to Eventhub CaptureDescription #5105

Conversation

v-Ajnava commented Jan 28, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Jan 28, 2019

AutorestCI commented Jan 28, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jan 28, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jan 28, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jan 28, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jan 28, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jan 28, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Jan 28, 2019

jianghaolu Jan 28, 2019

Choose a reason for hiding this comment

v-Ajnava Jan 29, 2019

Choose a reason for hiding this comment

v-Ajnava commented Jan 30, 2019

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading

AutorestCI commented Jan 28, 2019 •

edited

Loading