Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk #5042

Merged
merged 9 commits into from
Mar 2, 2019
Merged

Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk #5042

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5269a33
Fixes for:
binilkk Dec 11, 2018
0d7d1ac
Merge branch 'master' of https://github.com/azure/azure-rest-api-spec…
binilkk Dec 14, 2018
010817d
Merge branch 'master' of https://github.com/azure/azure-rest-api-spec…
binilkk Jan 15, 2019
b251b90
Updated the Specification as example for Risky IP Download report.
binilkk Jan 15, 2019
515dcb5
Added the Result details
binilkk Jan 16, 2019
77abaa8
Merge branch 'master' of https://github.com/azure/azure-rest-api-spec…
binilkk Feb 5, 2019
00a8482
Fixed review comments, changed the URI scheme as well as changed get/…
binilkk Feb 5, 2019
37ed054
Merge branch 'master' of https://github.com/azure/azure-rest-api-spec…
binilkk Feb 22, 2019
74422c4
Addressing Review Feedback, changing POST call of blobUri -> generate…
binilkk Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions ...urce-manager/Microsoft.ADHybridHealthService/stable/2014-01-01/ADHybridHealthService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3258,6 +3258,70 @@
}
}
}
},
"/providers/Microsoft.ADHybridHealthService/services/{serviceName}/reports/riskyIp/GetAllBlobUri": {
binilkk marked this conversation as resolved.
Show resolved Hide resolved
"get": {
"tags": [ "Reports" ],
"description": "Gets all the blob uri for the risky ip download report requested for a given service for last 7 days.",
"x-ms-examples": {
"services_listAllRiskyIpDownloadReport": {
"$ref": "./examples/RiskyIpDownload.json"
}
},
"operationId": "services_listAllRiskyIpDownloadReport",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operationId should not be camel-cased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joel, Gaurav from ARM team has signed off, could you please sign off so that I can merge? I don't have permissions to merge, am I correct in guessing that your signoff will cause merge to happen?

"parameters": [
{
"name": "serviceName",
"in": "path",
"description": "The name of the service.",
"required": true,
"type": "string"
},
{
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
"200": {
"description": "The list of blob uri for the risky ip download report requested for a given service for last 7 days.",
}
},
"x-ms-pageable": {
"nextLinkName": null
}
}
},
"/providers/Microsoft.ADHybridHealthService/services/{serviceName}/reports/riskyIp/GetBlobUri": {
binilkk marked this conversation as resolved.
Show resolved Hide resolved
"get": {
"tags": [ "Reports" ],
"description": "Gets only the current requested risky ip download report for a given service.",
"x-ms-examples": {
"services_listCurrentRiskyIpDownloadReport": {
"$ref": "./examples/RiskyIpDownload.json"
}
},
"operationId": "services_listCurrentRiskyIpDownloadReport",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operationId should not be camel-cased.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make the change. It seems I'll have to fix it for the whole document though. Is there any implication to the spec for changing it everywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave it as-is then for consistency with the rest of the docs. It's highly likely that there's zero impact to codegen as most generators probably fix the casing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. So are we good to go with this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once @KrisBash signs off from ARM side I will complete my review.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Joel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KrisBash, could you please take a look?

"parameters": [
{
"name": "serviceName",
"in": "path",
"description": "The name of the service.",
"required": true,
"type": "string"
},
{
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
"200": {
"description": "The blob URI for the currently requested risky ip download report for a given service.",
}
},
"x-ms-pageable": {
"nextLinkName": null
}
}
}
},
"definitions": {
Expand Down
22 changes: 22 additions & 0 deletions ...e-manager/Microsoft.ADHybridHealthService/stable/2014-01-01/examples/RiskyIpDownload.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"serviceName": "sampleServiceName",
"api-version": "2014-01-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"tenantId": "TenantId of the tenant.",
"serviceId": "ServiceId of the tenant.",
"resultSasUri": "SAS Uri of the blob.",
"blobCreateDateTime": "2019-01-07T20:32:02+00:00",
"jobCompletionTime": "2019-01-07T20:32:05+00:00",
"status": "status of the task."
}
]
}
}
}
}