Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory] Add Azure Function to Swagger #5010

Merged
merged 5 commits into from
Jan 18, 2019
Merged

[Datafactory] Add Azure Function to Swagger #5010

merged 5 commits into from
Jan 18, 2019

Conversation

arsunda
Copy link
Contributor

@arsunda arsunda commented Jan 9, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 9, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from anuchandy January 9, 2019 21:18
@AutorestCI AutorestCI mentioned this pull request Jan 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jan 9, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 9, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3914

@AutorestCI AutorestCI mentioned this pull request Jan 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 9, 2019 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

@AutorestCI AutorestCI mentioned this pull request Jan 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 9, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

@AutorestCI AutorestCI mentioned this pull request Jan 9, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 9, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

hvermis
hvermis requested changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@hvermis hvermis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only make changes in our GA version

@arsunda
Copy link
Contributor Author

arsunda commented Jan 11, 2019

@anuchandy anything remaining for this PR?

anuchandy
anuchandy requested changes Jan 14, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arsunda if I understand correctly the only change in LinkedService.json is function specific, but there are many unnecessry tab/space changes in other places which makes review hard, can you fix them and make sure we see only relevant changes?

...tory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json Show resolved Hide resolved
@AutorestCI AutorestCI mentioned this pull request Jan 17, 2019
Closed
@arsunda
Copy link
Contributor Author

arsunda commented Jan 18, 2019

@anuchandy What about the license/cla check? Why has it not completed

@anuchandy
Copy link
Member

@arsunda license/cla is green now.

@sarangan12 - jfy this PR also fails to run opendeff tool (PR is based on fairly new branch).

@anuchandy anuchandy merged commit ee9ed42 into Azure:master Jan 18, 2019
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jan 18, 2019
Merged
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jan 18, 2019
Merged
@arsunda arsunda mentioned this pull request Jan 18, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@arsunda @AnuTalluri
[Datafactory] Add Azure Function to Swagger (Azure#5010)
c07c57d 
* Azure Function changes

* remove from preview version

* undo preview changes fully

* update defn

* update object to secret base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arsunda @AutorestCI @azuresdkci @anuchandy @jhendrixMSFT @hvermis