Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Grid 2019-01-01 API Version: Swagger and related test examples #4899

Merged
merged 18 commits into from
Dec 17, 2018
Merged

Event Grid 2019-01-01 API Version: Swagger and related test examples #4899

merged 18 commits into from
Dec 17, 2018

Conversation

ahamad-MS
Copy link
Contributor

@ahamad-MS ahamad-MS commented Dec 12, 2018 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • [] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#674

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3751

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2012

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3959

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4286

@AutorestCI
Copy link

AutorestCI commented Dec 12, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2206

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Dec 13, 2018
Merged
Merged
Merged
Merged
Merged
Merged
@sarangan12
Copy link
Member

Please fix the errors reported in https://travis-ci.org/Azure/azure-rest-api-specs/jobs/467369257

@sarangan12
Copy link
Member

Also since this is a new version, This needs ARM Approval. Adding appropriate label

@sarangan12 sarangan12 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 13, 2018
@kalyanaj
Copy link
Contributor

@sarangan12 , @ahamad-MS :

This is regarding the four examples issues at https://portal.azure-devex-tools.com/app/branch/ahamad-MS/azure-rest-api-specs/master/static.

This is a false positive. We have multiple EventSubscriptionDestination types (EventHubEventSubscriptionDestination, HybridConnectionEventSubscriptionDestination etc.) and each of them has corresponding property classes e.g. EventHubEventSubscriptionDestinationProperties and HybridConnectionEventSubscriptionDestinationProperties have both a property called resourceId which is why the validation appears to be flagging this. However, the discriminator value (endpointType) is separate for each of these destinations, hence based on the discriminator it will get deserialized into the appropriate type.

I tried to submit a suppression request from the OpenAPI hub portal, but it fails with "Sorry, something went wrong." (tried in all browsers), hence updating it here.

@ahamad-MS
Copy link
Contributor Author

@kalyanaj @sarangan12 the suppression request finally went through and cleared the false alarm issue. I don't see any more validation issues yet Model validator task is still shown ad neutral. is this expected? anything to be addressed here?

@ahamad-MS
Copy link
Contributor Author

@KrisBash @sarangan12 Can you please let us know if there is any feedback/comments to be addressed from our side. We would like to get this PR finalized today if possible. Thanks a lot.

@sarangan12 sarangan12 merged commit 92a9287 into Azure:master Dec 17, 2018
@kpajdzik kpajdzik removed the review label Dec 17, 2018
@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 17, 2018
This was referenced Dec 18, 2018
Closed
Merged
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@ahamad-MS @AnuTalluri
Event Grid 2019-01-01 API Version: Swagger and related test examples (A…
51cc8f6 
…zure#4899)

* EventGrid: Update README files to include the current new preview api version 2018-09-preview

* Update readme.go.md with related api version info

* fix parsing failure due to missing closing ``` in readme.go.md

* suppress failure due to known tool bug per approval from adxsr

* Fix suppression message

* add swagger and fix related examples for EventGrid 2019-01-01 API Version

* Fix name mismatch in eventgrid.json in the examples to fix build failure

* fix readme files to reflect correct location to eventgrid json file for stable version

* remove 2019-01-01 from not dot NET multi-api  sections to avoid auto-generating the corresponding SDKs

* fix text

* fix examples

* Fix examples

* Suppress failure due to known tool bug

* example fixes

* Adds suppression to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ahamad-MS @AutorestCI @azuresdkci @sarangan12 @kalyanaj @KrisBash @kpajdzik