Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portal Generated] Review request for Microsoft.ADHybridHealthService to add version 2014-01-01 #4880

Merged
merged 2 commits into from
Dec 14, 2018
Merged

[Portal Generated] Review request for Microsoft.ADHybridHealthService to add version 2014-01-01 #4880

merged 2 commits into from
Dec 14, 2018

Conversation

binilkk
Copy link
Contributor

@binilkk binilkk commented Dec 11, 2018

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@binilkk
Fixes for:
5269a33 
Issue Azure#1 : Azure#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue Azure#2 : Azure#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3883

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2775

@AutorestCI AutorestCI mentioned this pull request Dec 11, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 11, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3727

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@praries880
Copy link

@azuresdkci test this please

@praries880
Copy link

ill close and re-open the PR for it to pick up changes in : #4893

@praries880 praries880 closed this Dec 14, 2018
@praries880 praries880 reopened this Dec 14, 2018
@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@praries880
Copy link

@binilkk can you sync your branch with upstream master to pull in the fix for #4893? this will fix the java build error

@binilkk
Copy link
Contributor Author

binilkk commented Dec 14, 2018 via email •
edited
Loading

@binilkk
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs …
0d7d1ac 
…into dev-adhybridhealthservice-Microsoft.ADHybridHealthService-2014-01-01-binilkk
@AutorestCI AutorestCI mentioned this pull request Dec 14, 2018
Merged
@praries880 praries880 merged commit 6d8b202 into Azure:master Dec 14, 2018
@kpajdzik kpajdzik removed the review label Dec 14, 2018
@nschonni nschonni mentioned this pull request Dec 14, 2018
Closed
@nschonni nschonni mentioned this pull request Dec 14, 2018
Closed
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@binilkk @AnuTalluri
Fixes for: (Azure#4880)
63a57f6 
Issue #1 : Azure#4576 (comment)

Typo in the DeltaOperationType Enum.

Issue #2 : Azure#4844 (comment)

GlobalAdmins list is marked as an object, while it's an array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 praries880 approved these changes

Assignees

@praries880 praries880

Labels
potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@binilkk @AutorestCI @azuresdkci @praries880 @anuchandy @kpajdzik