Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sync scenarios to public preview swagger #4627

Merged
merged 9 commits into from
Dec 14, 2018
Merged

Adding sync scenarios to public preview swagger #4627

merged 9 commits into from
Dec 14, 2018

Conversation

ash1625
Copy link
Contributor

@ash1625 ash1625 commented Nov 29, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 29, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3814

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#519

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2603

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4123

@AutorestCI AutorestCI mentioned this pull request Nov 29, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 29, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3728

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2018
neetusingh-ms
neetusingh-ms approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@neetusingh-ms neetusingh-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ashish.

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@praries880
Copy link

@ravbhatnagar can you kindly take a look at this?

@ravbhatnagar
Copy link
Contributor

@ash1625 - There are a lot of changes in this PR. It might be quicker to review this over a meeting. Please feel to set something up with GauravBh and armapireview.

@ravbhatnagar ravbhatnagar mentioned this pull request Dec 14, 2018
Open
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 14, 2018
@ravbhatnagar
Copy link
Contributor

Signing off from ARM side. Noted few issues during the in-person review. Service team is close to GA and may not be able to likely fix it for this api-version. But will likely consider for the next one.

  1. Rename "errors" in MigrateSyncCompleteCommandOutput properties.
  2. How to get information of all the commands on a task.
  3. Implementation for updating an existing tasks.
  4. migrationSetting/sourceSetting/targetSetting object (expand this object for known properties ) good for CLI/powershell users.

@praries880 praries880 merged commit b2b7f82 into Azure:master Dec 14, 2018
@ash1625 ash1625 mentioned this pull request Jan 8, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@ash1625 @AnuTalluri
Adding sync scenarios to public preview swagger (Azure#4627)
e0cd02b 
* Adding sync scenarios to public preview swagger

* Fix comments on pull request

* Add files to GA folder

* Add missing file to swagger in GA folder

* remove mongoDB chnages from stable folder

* add orphaned user changes to the repo

* minor string fix

* Change orphanedUsers to orphanedUsersInfo

* Change orphanedUsers to orphanedUsersInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 praries880 approved these changes

@hitenjava hitenjava hitenjava approved these changes

@neetusingh-ms neetusingh-ms neetusingh-ms approved these changes

@sichoudh sichoudh Awaiting requested review from sichoudh

@swjain23 swjain23 Awaiting requested review from swjain23

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ash1625 @azuresdkci @AutorestCI @praries880 @ravbhatnagar @neetusingh-ms @hitenjava