Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventHub : Revert PR 4246 from 2017 and added Kafka enabled #4321

Merged
merged 3 commits into from
Oct 26, 2018
Merged

EventHub : Revert PR 4246 from 2017 and added Kafka enabled #4321

merged 3 commits into from
Oct 26, 2018

Conversation

v-Ajnava
Copy link
Member

Note: We have reverted the PR #4246, as there are more service side changes, VNet team wants to standardize there APIs which will changes few VNet and IPFilter rules API. So we are reverting these API from the stable 2017 swagger.

No Clients were published with PR #4246

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from anuchandy October 24, 2018 22:21
@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3240

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

This was referenced Oct 24, 2018
Closed
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1804

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3152

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Merged
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3970

@v-Ajnava
Copy link
Member Author

@anuchandy , can you please take a look, actually Kafka GA is on 11/07 and the PS and CLI release are on 1106 and 1107 with code freeze on 1029. let me know on the PR, if you need a call to explain the revert of this PR.

@anuchandy
Copy link
Member

@v-Ajnava thank you. Based on our discussion over email -

Service doesn’t support VNet and IPFilter on the 2017-04-01 API version. Hence this is not a breaking change and this revert is to ensure consistent VNet experience across services.

As discussed please use the "Do not merge" tag for such PRs so that reviewers don't merge them accidentally.

Merging this PR.

@anuchandy anuchandy merged commit 01eb8f2 into Azure:master Oct 26, 2018
@AutorestCI
Copy link

AutorestCI commented Oct 26, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2153

@AutorestCI AutorestCI mentioned this pull request Oct 26, 2018
Merged
@v-Ajnava v-Ajnava mentioned this pull request Oct 27, 2018
Closed
9 tasks
@rrama-Microsoft rrama-Microsoft mentioned this pull request Oct 29, 2018
Merged
9 tasks
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@srswamy-msft @nbikhchandani @xxinlPuzzle
Adding session cluster specs, cluster connectivity profile property, …
ec48536 
…and other breaking changes. (#4321)

* Add session cluster specs and cluster connectivity profile

* Adding changes for identityProfile, authProfile, secretsProfile and serviceConfigs

* Fixing validation errors

* Adding missing identity and auth profile in cluster properties

* Adding missing identity and auth profile in cluster properties

* Rename clustertypeversions to clusterofferingversions

* Fix schema violation error

* Fix tool check errors

* Add missing identity profile properties

Co-authored-by: Namrata Bikhchandani <nabikhch@microsoft.com>
Co-authored-by: xinli1 <xinli1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-Ajnava @AutorestCI @azuresdkci @anuchandy