Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to add operation id for outbound rules #4320

Merged
merged 6 commits into from
Oct 29, 2018
Merged

Changes to add operation id for outbound rules #4320

merged 6 commits into from
Oct 29, 2018

Conversation

khannarhea
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3131

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3951

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3687

@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 24, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 24, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#1800

@MikhailTryakhov
Copy link
Contributor

@kkhannarhea please fix failed tests

This was referenced Oct 25, 2018
Merged
Merged
Merged
@EvgenyAgafonchikov
Copy link
Contributor

@khannarhea, could you please change line endings in loadBalancer.json back to LF (now CRLF). Currently it is difficult to find in diff where the change is.

@EvgenyAgafonchikov
Copy link
Contributor

@khannarhea, I created PR with some fixes by @MikhailTryakhov's request: khannarhea#1. Please merge it to fix CI issues and revert line endings to default

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 29, 2018
@khannarhea
Merge pull request #1 from EvgenyAgafonchikov/fix-lb
a9023fb 
Fixed line endings, specs, examples
@khannarhea
Copy link
Contributor Author

thanks @EvgenyAgafonchikov and @MikhailTryakhov - i have merged the branch

@AutorestCI
Copy link

AutorestCI commented Oct 29, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

ryansbenson
ryansbenson approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

specification/network/resource-manager/Microsoft.Network/stable/2018-08-01/loadBalancer.json
}
],
"responses": {
"200": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include a 'default' response for all error cases, example: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/msi/resource-manager/Microsoft.ManagedIdentity/preview/2015-08-31-preview/ManagedIdentity.json

      "default": {
        "description": "Error response describing why the operation failed.",
        "schema": {
          "$ref": "#/definitions/CloudError"
        }
      }

This should be addressed across your entire Swagger spec though. Please include this in your next PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will address it in the next PR - Tracking item - https://trello.com/c/HrzSc9bZ/69-include-a-default-response-for-all-error-cases

@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 29, 2018
@sergey-shandar
Copy link
Contributor

@khannarhea are you going to address default response issues?

@MikhailTryakhov
Copy link
Contributor

@sergey-shandar do we need anything? Or can merge?

@sergey-shandar sergey-shandar merged commit e8f2b49 into Azure:network-october-release Oct 29, 2018
lmazuel added a commit that referenced this pull request Oct 30, 2018
@lmazuel
Network october release (#4040)
bc2b135 
* Updated NetworkConfigurationDiagnostic API + example (#3905)

* Fix incorrect API versions in Network's examples (#3954)

* Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json

* Fixed incorrect API version in 2018-07-01 example

* swagger change for application gateway waf global config and exclusion list (#3972)

* swagger change for application gateway waf global config and exclusion list

* address the comments

* add customer error spec for Application Gateway (#3985)

* add customer error spec for Application Gateway

* fix property name issue

* Add ICMP to the list of supported protocols (#3993)

* change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050)

* add customer error spec for Application Gateway

* fix property name issue

* change appgw custom error status code enum and fix a typo of customErrorConfiguration

* Add ExpressRoutePort swagger (#4104)

* Add ExpressRoutePort details to readme.md

* ExpressRoutePort swagger

* Refer SubscriptionIdParameter and ApiVersionParameter from network.json

* Cherry pick NRP's changes from master to October branch (#4251)

* Remove error code from swagger (#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error

* Changes to add operation id for outbound rules (#4320)

* Changes to add operation id for outbound rules

* Changes to make outbound rule similar to load balancing rule

* fix failures - add example json files

* fix failures

* Fixed line endings, specs, examples

* Change one parameter (#4339)

* Change parameter in most recent version

* Fix example

* New SKU for ER (#4342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson approved these changes

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@khannarhea @AutorestCI @azuresdkci @MikhailTryakhov @EvgenyAgafonchikov @sergey-shandar @ryansbenson @khannarheams