Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM endpoint, update model responses/inputs to align with expected values #4015

Merged
merged 13 commits into from
Oct 19, 2018
Merged

Add ARM endpoint, update model responses/inputs to align with expected values #4015

merged 13 commits into from
Oct 19, 2018

Conversation

r-delgadillo
Copy link
Contributor

@r-delgadillo r-delgadillo commented Sep 27, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#252

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3137

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3917

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2413

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1572

@AutorestCI AutorestCI mentioned this pull request Sep 27, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@r-delgadillo
Copy link
Contributor Author

Add @emgarten @zzcodework @amrenbin @cle5eland

jianghaolu
jianghaolu reviewed Oct 2, 2018
View reviewed changes
...ification/iotcentral/resource-manager/Microsoft.IoTCentral/stable/2018-09-01/iotcentral.json
@@ -537,22 +583,37 @@
},
"ErrorDetails": {
"description": "Error details.",
"properties": {
"error": {
"$ref": "#/definitions/ErrorResponseBody"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add x-ms-flatten: true to reduce breaking change from the client side

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/Azure/autorest/blob/master/docs/extensions/readme.md#x-ms-client-flatten for documentation.

Copy link
Contributor Author

@r-delgadillo r-delgadillo Oct 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@jianghaolu
Copy link
Contributor

https://github.com/Azure/azure-rest-api-specs/pull/4015/files#diff-23bf8d6e84c93efe6c0e1b736fb4a61cR716 is a breaking change but the original spec was incorrectly describing the API. Merge as a fix.

@jianghaolu jianghaolu changed the title IoTCentral - Add ARM endpoint, update model responses/inputs to align with expected values [Do not merge] IoTCentral - Add ARM endpoint, update model responses/inputs to align with expected values Oct 2, 2018
@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
KrisBash
KrisBash approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off from ARM

@jianghaolu jianghaolu merged commit 17fe887 into Azure:master Oct 19, 2018
@AutorestCI AutorestCI mentioned this pull request Oct 19, 2018
Merged
@jhendrixMSFT
Copy link
Member

@AutorestCI rebase azure-sdk-for-go

@AutorestCI
Copy link

I didn't understand your command:

rebase azure-sdk-for-go

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

4 similar comments
@AutorestCI
Copy link

I didn't understand your command:

rebase azure-sdk-for-go

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

rebase azure-sdk-for-go

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

rebase azure-sdk-for-go

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

rebase azure-sdk-for-go

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

@r-delgadillo r-delgadillo changed the title [Do not merge] IoTCentral - Add ARM endpoint, update model responses/inputs to align with expected values Add ARM endpoint, update model responses/inputs to align with expected values Oct 22, 2018
@r-delgadillo r-delgadillo mentioned this pull request Oct 22, 2018
Merged
9 tasks
@r-delgadillo r-delgadillo deleted the dev-iotcentral branch April 30, 2019 16:27
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@limingu
[Nginx] Add swagger 2021-05-01-preview version (#4015)
9c1caa1 
* [Nginx] Add swagger 2021-05-01-preview version

* Fix

* Update

* update

* example

* Fix

* Update

* Update

* Fix

* Update

* Update

* Update

* Feedback

* Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisBash KrisBash KrisBash approved these changes

@amrenbin amrenbin amrenbin approved these changes

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@r-delgadillo @AutorestCI @azuresdkci @jianghaolu @jhendrixMSFT @amrenbin @KrisBash