New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger change for listing virtual machines in a subscription by location #3958

Closed

dochung4 wants to merge 10 commits into Azure:master from dochung4:locations_virtualMachines

Contributor

dochung4 commented Sep 19, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

[y] The title of the PR is clear and informative.
[y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[y] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[y] If applicable, the PR references the bug/issue that it fixes.
[y] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[y] I have read the contribution guidelines.
[y] My spec meets the review criteria:
- [y] The spec conforms to the Swagger 2.0 specification.
- [y] The spec follows the guidelines described in the Swagger checklist document.
- [y] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

dochung4 added 5 commits

July 2, 2018 11:50


          Added listing all availability sets in a subscription and StandardSSD…

c34f1fd

…_LRS to 2018-06-01


          Added a missing comma

3a34c2f


          First commit - added status to BootDiagnosticsInstanceView

9a29555


          Merge remote-tracking branch 'upstream/master'

ea3e354


          Updated compute.json

fb36849

AutorestCI commented Sep 19, 2018 •

edited

Loading

Automation for azure-sdk-for-js

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

apimanagement/resource-manager
azsadmin/resource-manager/backup/Microsoft.Backup.Admin
machinelearningservices/resource-manager
dns/resource-manager
eventgrid/resource-manager
containerservices/resource-manager
authorization/resource-manager
storSimple1200Series/resource-manager
cognitiveservices/data-plane/LUIS/Authoring
compute/resource-manager
azsadmin/resource-manager/backup
network/resource-manager
resources/resource-manager
monitor/data-plane
databox/resource-manager
automation/resource-manager
recoveryservicesbackup/resource-manager
datalake-analytics/data-plane
signalr/resource-manager
monitor/resource-manager
sql/resource-manager
azure-kusto/resource-manager
datafactory/resource-manager
cost-management/resource-manager

azuresdkci assigned lmazuel

azuresdkci requested a review from lmazuel

September 19, 2018 21:52

Contributor

azuresdkci commented Sep 19, 2018

Can one of the admins verify this patch?

AutorestCI commented Sep 19, 2018 •

edited

Loading

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

containerservices/resource-manager
signalr/resource-manager
dns/resource-manager
authorization/resource-manager
datafactory/resource-manager
cost-management/resource-manager
databox/resource-manager
monitor/data-plane
azsadmin/resource-manager/backup
sql/resource-manager
apimanagement/resource-manager
datalake-analytics/data-plane
recoveryservicesbackup/resource-manager
cognitiveservices/data-plane/LUIS/Authoring
automation/resource-manager
azsadmin/resource-manager/backup/Microsoft.Backup.Admin
monitor/resource-manager
compute/resource-manager
azure-kusto/resource-manager
machinelearningservices/resource-manager
storSimple1200Series/resource-manager
eventgrid/resource-manager
network/resource-manager
resources/resource-manager

AutorestCI commented Sep 19, 2018 •

edited

Loading

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

network/resource-manager
sql/resource-manager
automation/resource-manager
containerservices/resource-manager
machinelearningservices/resource-manager
datalake-analytics/data-plane
databox/resource-manager
azsadmin/resource-manager/backup
azsadmin/resource-manager/backup/Microsoft.Backup.Admin
datafactory/resource-manager
monitor/resource-manager
apimanagement/resource-manager
resources/resource-manager
monitor/data-plane
dns/resource-manager
azure-kusto/resource-manager
cognitiveservices/data-plane/LUIS/Authoring
recoveryservicesbackup/resource-manager
storSimple1200Series/resource-manager
cost-management/resource-manager
eventgrid/resource-manager
authorization/resource-manager
compute/resource-manager
signalr/resource-manager

This was referenced Sep 19, 2018

[AutoPR compute/resource-manager] Swagger change for listing virtual machines in a subscription by location Azure/azure-sdk-for-python#3382

Closed

[AutoPR compute/resource-manager] Swagger change for listing virtual machines in a subscription by location Azure/azure-sdk-for-ruby#1668

Closed

AutorestCI commented Sep 19, 2018 •

edited

Loading

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

cost-management/resource-manager
azsadmin/resource-manager/backup
databox/resource-manager
signalr/resource-manager
machinelearningservices/resource-manager
cognitiveservices/data-plane/LUIS/Authoring
monitor/resource-manager
dns/resource-manager
datalake-analytics/data-plane
recoveryservicesbackup/resource-manager
network/resource-manager
azure-kusto/resource-manager
authorization/resource-manager
datafactory/resource-manager
automation/resource-manager
azsadmin/resource-manager/backup/Microsoft.Backup.Admin
containerservices/resource-manager
resources/resource-manager
sql/resource-manager
storSimple1200Series/resource-manager
compute/resource-manager
eventgrid/resource-manager
monitor/data-plane
apimanagement/resource-manager

AutorestCI commented Sep 19, 2018 •

edited

Loading

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

monitor/data-plane
datafactory/resource-manager
eventgrid/resource-manager
compute/resource-manager
apimanagement/resource-manager
azure-kusto/resource-manager
cognitiveservices/data-plane/LUIS/Authoring
databox/resource-manager
automation/resource-manager
cost-management/resource-manager
dns/resource-manager
signalr/resource-manager
azsadmin/resource-manager/backup/Microsoft.Backup.Admin
monitor/resource-manager
recoveryservicesbackup/resource-manager
machinelearningservices/resource-manager
resources/resource-manager
network/resource-manager
azsadmin/resource-manager/backup
sql/resource-manager
datalake-analytics/data-plane
authorization/resource-manager
containerservices/resource-manager
storSimple1200Series/resource-manager

AutorestCI mentioned this pull request

[AutoPR compute/resource-manager] Swagger change for listing virtual machines in a subscription by location Azure/azure-sdk-for-java#2409

Closed

AutorestCI commented Sep 19, 2018 •

edited

Loading

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

datalake-analytics/data-plane
compute/resource-manager
network/resource-manager
authorization/resource-manager
datafactory/resource-manager
dns/resource-manager
resources/resource-manager
eventgrid/resource-manager
containerservices/resource-manager
apimanagement/resource-manager
databox/resource-manager
machinelearningservices/resource-manager
azsadmin/resource-manager/backup/Microsoft.Backup.Admin
automation/resource-manager
azsadmin/resource-manager/backup
monitor/data-plane
azure-kusto/resource-manager
cognitiveservices/data-plane/LUIS/Authoring
storSimple1200Series/resource-manager
monitor/resource-manager
cost-management/resource-manager
signalr/resource-manager
sql/resource-manager
recoveryservicesbackup/resource-manager


          Updated description

31ddb82

Contributor

hyonholee commented Sep 21, 2018

Please update stable\2018-10-01\compute.json file too.

dochung4 added 4 commits

September 21, 2018 13:31


          Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

ad89dca


          Updated 2018-10-01

d8ca391


          Updated description

fe24c02


          Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

a1f6eb0

…into locations_virtualMachines

dochung4 requested review from MikhailTryakhov, kay-owolabi and yangyuan as code owners

September 21, 2018 20:52

dochung4 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet