Swagger changes for adding diffdisksettings property for the Ephemeral OS Disks

[hari-bodicherla]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[msftclas]

All CLA requirements met.

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3383

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3681

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1577

[AutorestCI]

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2780

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[jhendrixMSFT]

Can you please update at least one of the examples with this new field?

[hari-bodicherla]

Added a example "CreateAScaleSetWithDiffOsDisk.json" using the new field as requested

[jhendrixMSFT]

@AutorestCI regenerate azure-sdk-for-go

[jhendrixMSFT]

@hari-bodicherla thanks for adding the example, the only thing remaining is to update the appropriate operation ID in compute.json to reference it. Once that's done and model validation passed I can merge.

[hyonholee]

Please also update stable\2018-10-01\compute.json (and examples under 2018-10-01 folder)

[hari-bodicherla]

updated the operation ID in compute.json to reference the new example file added

[hari-bodicherla]

Updated compute.json and examples under 2018-10-01 folder

[jhendrixMSFT]

This will introduce a breaking change. Looks like it can't be avoided though due to the name collision?

[jhendrixMSFT]

Oh nevermind this is part of the original commit.

[jhendrixMSFT]

@AutorestCI regenerate azure-sdk-for-go

[hari-bodicherla]

hi jhendrixMSFT , I am planning to add another example file for single Vm creation similar to scaleset creation using differencing os disk. Can we reopen this PR for these additional changes?

[jhendrixMSFT]

Sorry you'll have to add it it a new PR. Feel free to tag me in it and I'll help expedite the review.

[hari-bodicherla]

thanks jhendrixMSFT