Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure monitor] Add missing enum for aggregation type #3921

Merged
merged 2 commits into from
Sep 19, 2018
Merged

[Azure monitor] Add missing enum for aggregation type #3921

merged 2 commits into from
Sep 19, 2018

Conversation

binzhao-chn
Copy link
Contributor

@binzhao-chn binzhao-chn commented Sep 17, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1651

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3640

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2753

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 17, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2139

@binzhao-chn binzhao-chn changed the title Add missing enum for aggregation type [Azure monitor] Add missing enum for aggregation type Sep 17, 2018
@binzhao-chn binzhao-chn mentioned this pull request Sep 17, 2018
Open
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar
Copy link
Contributor

@gucalder please, review the PR.

gucalder
gucalder suggested changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@gucalder gucalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the comment.

@AutorestCI AutorestCI mentioned this pull request Sep 18, 2018
Merged
@sergey-shandar
Copy link
Contributor

@gucalder anything else?

@sergey-shandar sergey-shandar merged commit 109c990 into Azure:master Sep 19, 2018
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@sureleo @shul-msft
Fixing Java SDK warnings (#3921)
027a1da 
Co-authored-by: Shuo Li <shul@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gucalder gucalder gucalder requested changes

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Assignees

@sergey-shandar sergey-shandar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@binzhao-chn @AutorestCI @azuresdkci @sergey-shandar @gucalder