-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default response from Sessions #3868
Remove default response from Sessions #3868
Conversation
…emaining artifacts
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @refortie - the changes look okay, but are you aware that this will be a breaking change in your generated SDKs?
We generally recommend only adding breaking changes like this when you intend to release a new major version with service changes etc - but that's your call based on your customers and your service API release schedule :)
@annatisch That's fine. This is all part of a current versioning up that we are doing. Found this issue when generating and testing out the .Net SDK |
Remove default response from Sessions to bring them inline with the remaining artifacts
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger