Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grlin/updatingReqsforRA #3852

Merged
merged 6 commits into from
Sep 10, 2018
Merged

Conversation

grlin
Copy link
Contributor

@grlin grlin commented Sep 10, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3262

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3558

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2018

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#2379

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1619

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2613

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@annatisch
Copy link
Member

Thanks @grlin - was this an omission in the existing specs or is this a change in the service?

@grlin
Copy link
Contributor Author

grlin commented Sep 10, 2018 via email

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annatisch annatisch merged commit bf6da69 into Azure:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants