Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sensitivityLabels from sql readme.md #3833

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

jaredmoo
Copy link
Contributor

@jaredmoo jaredmoo commented Sep 7, 2018

There is a temporary issue with publishing the SDK containing this API, so it is removed from readme.md to avoid generating SDK.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

There is a temporary issue with publishing the SDK containing this API, so it is removed from readme.md to avoid generating SDK.
@jaredmoo
Copy link
Contributor Author

jaredmoo commented Sep 7, 2018

@nivimsft

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1562

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2614

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3561

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these changes are all in the preview folder, the breaking nature of these changes are not a concern.

@marstr marstr merged commit 65f8714 into Azure:master Sep 10, 2018
@jaredmoo
Copy link
Contributor Author

Thanks Martin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants