-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventGrid management APIs: Swagger for new Preview API version #3765
Conversation
…be default-valued. PATCH operation: 'EventSubscriptions_Update' Model Definition: 'EventSubscriptionUpdateParameters' Property: 'eventDeliverySchema'". 2) Updated the default value of EventDeliverySchema to the correct value used by the service.
…1-preview to make it easier to view the diffs).
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: dep ensure grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export golang.org/x/crypto:
(1) failed to list versions for https://go.googlesource.com/crypto: fatal: unable to access 'https://go.googlesource.com/crypto/': The requested URL returned error: 502
: exit status 128
|
To make it easier to review, the first three commits are just setting up the baseline (exact copy of the swagger + examples from the already shipped 2018-05-01-preview API version), commit 4 done today shows the diff for what's different between that API version and the new API version, and the new example files. |
@sarangan12 , can you please help take a look at this PR? This will enable us to move to the next steps of SDK generation/CLI etc. Thanks! Kalyan |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger