-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HANA instance restart API #3761
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than examples, which I think should definitely be added, LGTM
...naonazure/resource-manager/Microsoft.HanaOnAzure/preview/2017-11-03-preview/hanaonazure.json
Show resolved
Hide resolved
], | ||
"responses": { | ||
"202": { | ||
"description": "Accepted" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHat will happen if the restart fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will return a 404 if the instance is not found, 400 if the instance is not in a valid power state (ie: already restarting) and 500 if something on the server went wrong.
I noticed in the compute VM spec only has 200 and 202, do you not have to set all the return codes? or only the valid ones? Same on the GET VM, only 200.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger
I understand that this is meant to be an async API and should be using the
x-ms-long-running-operation
and thex-ms-long-running-operation-options
tags. However, our team is trying to demo this restart functionality next month (ran by us, not the customer) and we didn't have enough time to implement the async operations API. The intent of the demo is to execute this API (Either via the portal or CLI), and we will continuously call GET till it returns the correct state. This spec will be updated with the correct long-running tags and with operation APIs before we go public. My lead is aware of all of this and has approved it. Thank you for your understanding.