Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed BuildTask to FileTask and RunTask to EncodedTask in Azure Container registry Build GA swagger #3746

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

mnltejaswini
Copy link
Contributor

We have renamed some of the data models to reflect the data they represent. The example files are updated to reflect the new data models. There is no other change in the API.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3140

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3337

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2559

@AutorestCI
Copy link

AutorestCI commented Aug 28, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2176

@mnltejaswini
Copy link
Contributor Author

@jhendrixMSFT The SDKs for this swagger haven't yet merged in, It is still in development phase. So is it still a breaking change?

@jhendrixMSFT
Copy link
Member

@mnltejaswini Merging a swagger into this repo is considered a release event (we have already released an SDK for this swagger in the Go programming language). In addition, this swagger is in a stable directory.

@mnltejaswini
Copy link
Contributor Author

@jhendrixMSFT I see, thank you. Although the SDKs are available, the API is not yet available and exposed in ARM. so there aren't any potential customers

@jhendrixMSFT
Copy link
Member

@mnltejaswini When will the API be available? We should never merge a swagger into the public repo if the backing APIs aren't available.

@mnltejaswini
Copy link
Contributor Author

@jhendrixMSFT They will be available by 9/4

@jhendrixMSFT
Copy link
Member

@johanste @ravbhatnagar do we leave this swagger until the release date?

@johanste
Copy link
Member

@jhendrixMSFT - yes. We should update the title to include a [DO NOT MERGE] with this information included.

@jhendrixMSFT jhendrixMSFT merged commit e2aea08 into Azure:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants