Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace invalid-UTF-8 smart quotes #372

Merged
merged 5 commits into from
Jun 29, 2016
Merged

Replace invalid-UTF-8 smart quotes #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e8498c
Replace invalid UTF-8 with correct quotes
lvh Jun 26, 2016
4a72d87
Remove some EOL whitespace
lvh Jun 26, 2016
e30e3b5
Merge branch 'master' into cleanup
lvh Jun 29, 2016
ee31652
Check out compute from master
lvh Jun 29, 2016
660439b
Re-apply whitespace cleanup
lvh Jun 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arm-commerce/2015-06-01-preview/swagger/commerce.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation. It ONLY supports the �eq� and �and� logical operators at this time. All the 4 query parameters 'OfferDurableId', 'Currency', 'Locale', 'Region' are required to be a part of the $filter."
"description": "The filter to apply on the operation. It ONLY supports the 'eq' and 'and' logical operators at this time. All the 4 query parameters 'OfferDurableId', 'Currency', 'Locale', 'Region' are required to be a part of the $filter."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why the diff generator thinks eq changed but and didn't :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvh It's showing both 'eq' and 'and' changed, is that not what you expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I changed both of the quotes. But the diff generator thinks the word itself changed, which it didn't. I checked in the commit diff; it's just a GitHub display issue.

},
{
"$ref": "#/parameters/ApiVersionParameter"
Expand Down
6 changes: 3 additions & 3 deletions arm-compute/2016-03-30/swagger/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3661,7 +3661,7 @@
"vmId": {
"readOnly": true,
"type": "string",
"description": "the virtual machine unique id."
"description": "the virtual machine unique id."
}
},
"description": "Describes the properties of a Virtual Machine."
Expand Down Expand Up @@ -3875,7 +3875,7 @@
"$ref": "#/definitions/SubResource"
},
"description": "the application gateway backend address pools."
},
},
"loadBalancerBackendAddressPools": {
"type": "array",
"items": {
Expand Down Expand Up @@ -4573,4 +4573,4 @@
"description": "Client Api Version."
}
}
}
}