Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] Update default generation version for compute and runcommand to 2018-06-01 #3704

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Aug 22, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 22, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 22, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 22, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

@dsgouda
Copy link
Contributor

dsgouda commented Aug 22, 2018

@anuchandy Since this is compute, would you mind taking a look

@dsgouda dsgouda assigned anuchandy and unassigned dsgouda Aug 22, 2018
@AutorestCI
Copy link

AutorestCI commented Aug 22, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@dsgouda dsgouda requested review from anuchandy and removed request for dsgouda August 22, 2018 21:55
@AutorestCI
Copy link

AutorestCI commented Aug 22, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

- Microsoft.Compute/stable/2018-06-01/runCommands.json
- Microsoft.Compute/stable/2017-09-01/skus.json
- Microsoft.Compute/stable/2018-04-01/disk.json
- Microsoft.ContainerService/stable/2017-01-31/containerService.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyonholee - given container service is an RP by its own, do you know the reason behind shipping specific version 2017-01-31 of container service along with every compute releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will deprecate Container service after AKS Powershell cmdlets are delivered. If we remove container service now, then we need to remove all container service cmdlets from Powershell, which is a breaking change. So we will first deprecate container service Powershell cmdlets, and then remove this from Swagger spec and SDKs.

@anuchandy anuchandy changed the title [Compute] Update default generation version for compute and runcommand [Compute] Update default generation version for compute and runcommand to 2018-06-01 Aug 23, 2018
@anuchandy anuchandy merged commit e91e96e into Azure:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants