-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compute] Update default generation version for compute and runcommand to 2018-06-01 #3704
Conversation
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
@anuchandy Since this is compute, would you mind taking a look |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
- Microsoft.Compute/stable/2018-06-01/runCommands.json | ||
- Microsoft.Compute/stable/2017-09-01/skus.json | ||
- Microsoft.Compute/stable/2018-04-01/disk.json | ||
- Microsoft.ContainerService/stable/2017-01-31/containerService.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyonholee - given container service is an RP by its own, do you know the reason behind shipping specific version 2017-01-31 of container service along with every compute releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will deprecate Container service after AKS Powershell cmdlets are delivered. If we remove container service now, then we need to remove all container service cmdlets from Powershell, which is a breaking change. So we will first deprecate container service Powershell cmdlets, and then remove this from Swagger spec and SDKs.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger