Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move stable iotcentral Go SDK package out of preview directory #3630

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

jhendrixMSFT
Copy link
Member

The 2018-09-01 package was incorrectly placed under the preview
directory. Moved Go SDK config section to its own config file.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

The 2018-09-01 package was incorrectly placed under the preview
directory.  Moved Go SDK config section to its own config file.
@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3137

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3336

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1572

@AutorestCI
Copy link

AutorestCI commented Aug 13, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2458

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2018-09-01/$(namespace)
```

### Tag: package-2017-07-01-privatepreview and go

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really ? should we even leave that in ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im talking about hte privatepreview api

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emgarten do we need to keep building this API version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the privatepreview for go can be removed, this new stable version would be the first release

Copy link

@vladbarosan vladbarosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@emgarten emgarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @jhendrixMSFT 🍰

@jhendrixMSFT jhendrixMSFT merged commit b1347cc into Azure:master Aug 14, 2018
@jhendrixMSFT jhendrixMSFT deleted the iotcentralfix branch August 14, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants