Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS]modify credentialResults keyName to kubeconfigs #3606

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

zqingqing1
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3097

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3304

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Aug 8, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2422

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from anuchandy August 8, 2018 02:14
@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 8, 2018
@anuchandy anuchandy requested a review from ravbhatnagar August 8, 2018 06:19
@@ -1387,7 +1387,7 @@
},
"CredentialResults":{
"properties": {
"values": {
"kubeconfigs": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing property name of payload model in a stable api version is breaking change. Requesting ARM feedback here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake before, it should be 'kubeconfigs'. It is not a breaking change.

Copy link
Member

@anuchandy anuchandy Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a chat with @zqingqing1, 'kubeconfigs' is the name of the property from the beginning and usage of the property name "values" is a error in the swagger authoring. This PR simply fix this error.

@anuchandy anuchandy removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 8, 2018
@anuchandy anuchandy removed the request for review from ravbhatnagar August 8, 2018 16:32
@anuchandy anuchandy merged commit d497cdf into Azure:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants