Added allowGlobalReach flag in ExpressRouteCircuit.json #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syfarogh
requested review from
DeepakRajendranMsft and
MikhailTryakhov
as code owners
|
Can one of the admins verify this patch? |
syfarogh
changed the title
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmp748y0qwu/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp748y0qwu/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.109', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.109->2.1.110)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06"} .
Processing batch task - {"tag":"package-2018-04"} .
Shutting Down
Shutting Down
FATAL: go/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.go' terminated.
Failure during batch task - {"tag":"package-2018-04"} -- false. |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
jianghaolu
approved these changes
Jul 30, 2018
|
Please pull from latest |
Automation for azure-sdk-for-nodeA PR has been created for you: |
jianghaolu
pushed a commit
that referenced
this pull request
Aug 17, 2018
* Created folder for 2018-07-01 api version (#3509) * Created folder for 2018-07-01 api version * fixed incorrect encoding symbol * Fix lint diff and improve output on failure (#3528) Lint diff was failing on PRs with a base branch other than master. We needed to fetch the base branch ref from the origin before trying to resolve it to its commit hash. * Python conf for Network 2018-06 (#3535) * Py conf for Network 2018-07-01 (#3539) * Introduce Publicipprefix to swagger (#3520) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Publicipprefixaugust (#3573) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Service Endpoint Policies Swagger (#3558) * Service Endpoint Policies Swagger * Fix review comments * Updated Network Usage location parameter pattern (#3583) * Add enableTcpReset property to load balancer (#3545) * Add enableTcpReset property to load balancer. * Update loadbalancer examples with enableTcpReset. * added global reach flag (#3542) * fix query packet capture status in latest version (#3601) * Publicipprefixaugust (#3618) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Publicipprefixaugust (#3631) * Add PublicIpPrefix * Add PublicIpPrefix * Add PublicIpPrefix * Move to 2018-07-01 branch * revertversionchange * Fix Syntax error * Fix IpTag description because evidently everything is global * Fix $ref for PublicIpPrefix * Fix Casing * Add Exception for PublicIPPrefix from RequiredPropertiesMissingInResourceModel * Fix Version# * Fix Examples * Remove IdleTimeout parameter * Fix comma * Add PublicIpPrefix for PublicIpAddressConfiguration * Fix PublicIPAddress to refer to PublicIpPrefix as SubResource * Fix Comma * Remove compute update * Add PublicIpPrefix Subresource to VirtualMachineScaleSetPublicIPAddressConfigurationProperties * Changes to Support MSEEv2 Datapath for ExpressRoute. (#3647) Description of Changes: - Added a flag expressRouteGatewayBypass to the Connection Properties. - The user can set the flag to True to use MSEEv2 datapath Related work items: #2628003 * Added new API to networkwatcher.json and examples (#3650) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * Fix name from ServiceEndpointDefinition to ServiceEndpointDefinitions while doing a put, get and delete (#3655) * Add/Edit Outbound Rule on Load Balancer and Examples (#3592) * Add/Edit Outbound Rule on Load Balancer and Examples * Adding properties enabletcpreset, idletimeoutinminutes and protocol * Adding a reference to Public IP Prefix * Dummy Commit * Removed QueryConnectionMOnitors API (#3661) * Added new API to networkwatcher.json and examples * Added NetworkWatcherNetworkConfigurationDiagnostic example * removed QueryConnectionMonitors Api
5 tasks
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added allowGlobalReach flag in ExpressRouteCircuit.json for Global Reach feature