Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CreatePrivateZone example ref to swagger spec #3495

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

markjbrown
Copy link
Contributor

@markjbrown markjbrown commented Jul 24, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3000

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1444

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 24, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Jul 25, 2018

@lmazuel It looks like, the correct way to extend a model is to add "properties" inside "allOf" https://spacetelescope.github.io/understanding-json-schema/structuring.html#extending It's possible that AutoRest is smart enough to handle a case when "properties" are outside of "allOf".

@lmazuel
Copy link
Member

lmazuel commented Jul 25, 2018

After discussing with @sergey-shandar , merging with an OAV bug:
Azure/oav#280

Doesn't mean the Swagger is correct, but could be fixed later if the OAV bug is invalid.

@lmazuel lmazuel merged commit 9ac2c74 into Azure:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants