Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated description of sku name values #3467

Merged
merged 2 commits into from
Jul 20, 2018
Merged

updated description of sku name values #3467

merged 2 commits into from
Jul 20, 2018

Conversation

tfitzmac
Copy link
Contributor

@tfitzmac tfitzmac commented Jul 20, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [X ] The title of the PR is clear and informative.
  • [X ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [X ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from hovsepm July 20, 2018 19:10
@AutorestCI
Copy link

AutorestCI commented Jul 20, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jul 20, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jul 20, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2976

@AutorestCI
Copy link

AutorestCI commented Jul 20, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jul 20, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 20, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

smotwani
smotwani reviewed Jul 20, 2018
View reviewed changes
specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json Outdated
@@ -5909,7 +5909,7 @@
"properties": {
"name": {
"type": "string",
"description": "The sku name."
"description": "The sku name. Use **Aligned** for managed disks, and **Classic** for unmanaged disks."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the description of storageAccountType under ManagedDiskParameters. In order to be consistent with documentation I believe this should be updated to
The sku name. Possible values are: Aligned for managed disks, and Classic for unmanaged disks. Default value is Classic if not specified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Sameer's comment on adding a default text to let customers know default values.

@hovsepm hovsepm merged commit aa50b23 into Azure:master Jul 20, 2018
@AutorestCI AutorestCI mentioned this pull request Jul 20, 2018
Merged
tfitzmac added a commit to tfitzmac/azure-rest-api-specs that referenced this pull request Jul 23, 2018
@tfitzmac
Revert "updated description of sku name values (Azure#3467)"
e5a65ec 
This reverts commit aa50b23.
@tfitzmac tfitzmac mentioned this pull request Jul 23, 2018
Merged
jhendrixMSFT pushed a commit that referenced this pull request Jul 23, 2018
@tfitzmac @jhendrixMSFT
Revert "updated description of sku name values" (#3475)
9754d04 
* Revert "Enable Computer Vision Client to customize endpoint. (#3440)"

This reverts commit 6a7eb1d.

* Revert "Update custom image search Node.js properties (#3470)"

This reverts commit eddee65.

* Revert "updated description of sku name values (#3467)"

This reverts commit aa50b23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smotwani smotwani smotwani left review comments

@shandilvarun shandilvarun shandilvarun left review comments

@hovsepm hovsepm hovsepm approved these changes

Assignees

@hovsepm hovsepm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tfitzmac @AutorestCI @hovsepm @shandilvarun @smotwani