-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for a linter error related to default value in PATCH request body + use the correct default value in PUT #3367
Conversation
…be default-valued. PATCH operation: 'EventSubscriptions_Update' Model Definition: 'EventSubscriptionUpdateParameters' Property: 'eventDeliverySchema'". 2) Updated the default value of EventDeliverySchema to the correct value used by the service.
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Thanks @kalyanaj!
There's also a couple of model validation errors in the following samples:
|
@annatisch , regarding the additional linter error, that's an issue in the linter/validation tools, and it is being tracked by Azure/azure-openapi-arm-validator#10. I will take a look at the model validation errors. |
@annatisch, can I submit the fixes for the existing model validation errors in EventSubscriptions_GetForResource and EventSubscriptions_ListRegionalBySubscription in a separate pull request? As I am travelling this week, I would like to request that this current PR that covers the fix for the other unrelated linter issue get merged first to address the linter issue. |
Okay - I will follow up next week :) |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger