Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a linter error related to default value in PATCH request body + use the correct default value in PUT #3367

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

kalyanaj
Copy link
Contributor

@kalyanaj kalyanaj commented Jul 6, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

  1. Fix for a linter error: "Properties of a PATCH request body must not be default-valued. PATCH operation: 'EventSubscriptions_Update' Model Definition: 'EventSubscriptionUpdateParameters' Property: 'eventDeliverySchema'".
  2. [Non-breaking change] Fixing a bug in the Swagger in this preview API version where the mentioned default value for EventDeliverySchema didn't reflect the actual default value used by the service. Should have no effect on generated SDK code.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…be default-valued. PATCH operation: 'EventSubscriptions_Update' Model Definition: 'EventSubscriptionUpdateParameters' Property: 'eventDeliverySchema'".

2) Updated the default value of EventDeliverySchema to the correct value used by the service.
@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2902

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2698

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2206

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jul 6, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1464

@annatisch
Copy link
Member

annatisch commented Jul 9, 2018

Thanks @kalyanaj!
I see there's still an additional linter error - is there a plan to resolve this one as well?

"Tracked resource 'Topic' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well."

There's also a couple of model validation errors in the following samples:

  • EventSubscriptions_GetForResource
  • EventSubscriptions_ListRegionalBySubscription

@kalyanaj
Copy link
Contributor Author

kalyanaj commented Jul 9, 2018

@annatisch , regarding the additional linter error, that's an issue in the linter/validation tools, and it is being tracked by Azure/azure-openapi-arm-validator#10.

I will take a look at the model validation errors.

@kalyanaj
Copy link
Contributor Author

@annatisch, can I submit the fixes for the existing model validation errors in EventSubscriptions_GetForResource and EventSubscriptions_ListRegionalBySubscription in a separate pull request? As I am travelling this week, I would like to request that this current PR that covers the fix for the other unrelated linter issue get merged first to address the linter issue.

@annatisch
Copy link
Member

Okay - I will follow up next week :)

@annatisch annatisch merged commit 600a26e into Azure:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants