Add DatabaseVulnerabilityAssessments swagger #3275

ggildin · 2018-06-20T15:12:00Z

The put api is updated.
A new parameter is added to its body properties storageAccountAccessKey.
storageContainerSasKey isn't required anymore, but the user must to specified one of the following parameters:
storageContainerSasKey
or
storageAccountAccessKey

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

The put api is updated. A new parameter is added to its body properties storageAccountAccessKey. storageContainerSasKey isn't required anymore, but the user must to specified one of the following parameters: storageContainerSasKey or storageAccountAccessKey

AutorestCI · 2018-06-20T15:14:29Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

AutorestCI · 2018-06-20T15:16:45Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2138

AutorestCI · 2018-06-20T15:17:50Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1419

AutorestCI · 2018-06-20T15:20:29Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export golang.org/x/text: failed to fetch source for https://go.googlesource.com/text: unable to get repository: Cloning into '/tmp/tmpdvcqqc9a/pkg/dep/sources/https---go.googlesource.com-text'...
fatal: unable to access 'https://go.googlesource.com/text/': Failed to connect to go.googlesource.com port 443: Connection timed out
: command failed: [git clone --recursive -v --progress https://go.googlesource.com/text /tmp/tmpdvcqqc9a/pkg/dep/sources/https---go.googlesource.com-text]: exit status 128

AutorestCI · 2018-06-20T15:26:41Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3081

jaredmoo · 2018-06-20T16:59:17Z

Please look at travis CI failures

jaredmoo · 2018-06-20T16:59:48Z

Are api-versions other than 2017-10 affected?

ggildin · 2018-06-21T08:09:44Z

Hi.

I took a look on CI failures and fixed them.
Since it only add an optional (exclusive or) parameter, we don't think that a new api version is required. It doesn't break any user

lmazuel · 2018-06-21T22:46:14Z

@ggildin @jaredmoo The new file isn't plugged into any tags, is this on purpose?

jaredmoo · 2018-06-21T23:43:14Z

Let me rephrase my question. Here you are adding api-version 2017-10, but does api-version 2017-03 or earlier also contain the change?

add storageContainerPath to properties as optional parameters

ggildin · 2018-06-24T08:16:16Z

@yaakoviyun

yaakoviyun · 2018-06-24T08:27:11Z

...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json

@@ -261,12 +271,44 @@
        }
      }
    },
+    "Resource": {


please remove

yaakoviyun · 2018-06-24T08:27:33Z

...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json

    "DatabaseVulnerabilityAssessment": {
      "description": "A database vulnerability assessment.",
      "type": "object",
      "allOf": [
        {
-          "$ref": "../../../common/v1/types.json#/definitions/ProxyResource"
+          "$ref": "#/definitions/ProxyResource"


put

"$ref": "../../../common/v1/types.json#/definitions/ProxyResource"

yaakoviyun · 2018-06-24T08:30:12Z

...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json

+          ]
+        },
+        "storageAccountAccessKey": {
+          "description": "Specifies the identifier key of the auditing storage account. If 'StorageContainerSasKey' isn't specified, storageAccountAccessKey is required.",
          "type": "string",
          "x-ms-mutability": [
            "create",


"create",

"update"?

This reverts commit 7f90a83.

This reverts commit 9f34855.

This reverts commit 660b2f7.

The put api is updated. A new parameter is added to its body properties storageAccountAccessKey. storageContainerSasKey isn't required anymore, but the user must to specified one of the following parameters: storageContainerSasKey or storageAccountAccessKey

ggildin · 2018-06-24T09:21:38Z

Hi.

I synced with @yaakoviyun, we don't want to exposed at frontend a new version of the api. So I removed the swagger file for 2017-10-01 versions. (The auth generated tool generated them).
I updated the 2017-03-01 version files.
After this changes no swagger file is added, so no tag updating is required.
Regards Travis error - The failure is due to breaking change. Required field has been changed to be optional. As @jaredmoo and me talked in the CR, this is only a minor change and is acceptable.
Do I have any way to exclude this failure? @ravbhatnagar and @lmazuel - What is your opinion?

ravbhatnagar · 2018-06-27T08:00:51Z

Looks good.

jaredmoo · 2018-06-27T18:23:33Z

Please check travis errors:

ggildin · 2018-06-28T08:27:43Z

@jaredmoo - We talked on it. It due to moved one field to be optional.

clean databaseVulnerabilityAssessmentScans

ggildin · 2018-07-24T13:22:57Z

Hi @ravbhatnagar and @jaredmoo - our API id deployed world wide. Could you merge this pull request?
Thanks

jaredmoo · 2018-07-24T15:21:24Z

There is still model validation error: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/397699547

ggildin · 2018-07-25T07:05:58Z

fixed

lmazuel · 2018-07-25T20:46:16Z

@jaredmoo That's a preview Swagger, signed-of by ARM, and changes look good me. Once you think it's done, let me know and I merge the Pr.
Thanks!

azuresdkci assigned lmazuel Jun 20, 2018

azuresdkci requested a review from lmazuel June 20, 2018 15:12

AutorestCI mentioned this pull request Jun 20, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add DatabaseVulnerabilityAssessments swagger Azure/azure-sdk-for-java#2117

Merged

lmazuel requested a review from ravbhatnagar June 20, 2018 20:45

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 20, 2018

Add two missing example files

660b2f7

update databaseVulnerabilityAssessments for version 2017-03

7f90a83

add storageContainerPath to properties as optional parameters

This was referenced Jun 24, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add DatabaseVulnerabilityAssessments swagger Azure/azure-sdk-for-ruby#1418

Merged

[AutoPR sql/resource-manager] [DO NOT MERGE] Add DatabaseVulnerabilityAssessments swagger Azure/azure-sdk-for-go#2118

Merged

yaakoviyun reviewed Jun 24, 2018

View reviewed changes

ggildin added 4 commits June 24, 2018 11:32

Revert "update databaseVulnerabilityAssessments for version 2017-03"

8e9301f

This reverts commit 7f90a83.

Revert "Add DatabaseVulnerabilityAssessments swagger"

63de515

This reverts commit 9f34855.

Revert "Add two missing example files"

ed33cd7

This reverts commit 660b2f7.

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2018

Clean non required params in version 10-2017

6444d20

clean databaseVulnerabilityAssessmentScans

This was referenced Jun 28, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add DatabaseVulnerabilityAssessments swagger Azure/azure-sdk-for-python#2831

Merged

[AutoPR sql/resource-manager] [DO NOT MERGE] Add DatabaseVulnerabilityAssessments swagger Azure/azure-sdk-for-node#3081

Closed

ggildin changed the title ~~[DO NOT MERGE] Add DatabaseVulnerabilityAssessments swagger~~ Add DatabaseVulnerabilityAssessments swagger Jul 24, 2018

fix error in execute scan example

135edfb

jaredmoo approved these changes Jul 26, 2018

View reviewed changes

lmazuel merged commit 1a1da8d into Azure:master Jul 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DatabaseVulnerabilityAssessments swagger #3275

Add DatabaseVulnerabilityAssessments swagger #3275

ggildin commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

jaredmoo commented Jun 20, 2018

jaredmoo commented Jun 20, 2018

ggildin commented Jun 21, 2018 •

edited

Loading

lmazuel commented Jun 21, 2018 •

edited

Loading

jaredmoo commented Jun 21, 2018

ggildin commented Jun 24, 2018

yaakoviyun Jun 24, 2018

yaakoviyun Jun 24, 2018

yaakoviyun Jun 24, 2018

ggildin commented Jun 24, 2018 •

edited

Loading

ravbhatnagar commented Jun 27, 2018

jaredmoo commented Jun 27, 2018

ggildin commented Jun 28, 2018

ggildin commented Jul 24, 2018

jaredmoo commented Jul 24, 2018

ggildin commented Jul 25, 2018

lmazuel commented Jul 25, 2018

Add DatabaseVulnerabilityAssessments swagger #3275

Add DatabaseVulnerabilityAssessments swagger #3275

Conversation

ggildin commented Jun 20, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 20, 2018 • edited Loading

Automation for azure-sdk-for-node

jaredmoo commented Jun 20, 2018

jaredmoo commented Jun 20, 2018

ggildin commented Jun 21, 2018 • edited Loading

lmazuel commented Jun 21, 2018 • edited Loading

jaredmoo commented Jun 21, 2018

ggildin commented Jun 24, 2018

yaakoviyun Jun 24, 2018

Choose a reason for hiding this comment

yaakoviyun Jun 24, 2018

Choose a reason for hiding this comment

yaakoviyun Jun 24, 2018

Choose a reason for hiding this comment

ggildin commented Jun 24, 2018 • edited Loading

ravbhatnagar commented Jun 27, 2018

jaredmoo commented Jun 27, 2018

ggildin commented Jun 28, 2018

ggildin commented Jul 24, 2018

jaredmoo commented Jul 24, 2018

ggildin commented Jul 25, 2018

lmazuel commented Jul 25, 2018

ggildin commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

AutorestCI commented Jun 20, 2018 •

edited

Loading

ggildin commented Jun 21, 2018 •

edited

Loading

lmazuel commented Jun 21, 2018 •

edited

Loading

ggildin commented Jun 24, 2018 •

edited

Loading