Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fleet autoupgrade GA - add autoupgradeprofilestatus #32634

Open
wants to merge 2 commits into
base: release-aks-fleet-2025-03-01
Choose a base branch
from

Conversation

frantran
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Feb 14, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Feb 14, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerservicefleet/armcontainerservicefleet There is no API change compared with the previous version
JavaScript @azure/arm-containerservicefleet https://apiview.dev/Assemblies/Review/65c668ceaa2346708bf1e479b7f6b79b?revisionId=39feaceb98aa418b8ffeb60ab51ad2a9
Python azure-mgmt-containerservicefleet https://apiview.dev/Assemblies/Review/e0444ab348814233b7add2d104e5bcaa?revisionId=65750def57834222b4be09b81b138ede
Java azure-resourcemanager-containerservicefleet https://apiview.dev/Assemblies/Review/8422e73bfd5d45efb77d0cf066bec1a0?revisionId=a7ea0f8b7c1f45dea23cc92fdced27a2

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 14, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ContainerService

@frantran frantran changed the base branch from main to release-aks-fleet-2025-03-01 February 14, 2025 02:43
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview CI-RpaaSRPNotInPrivateRepo data-plane new-api-version NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS TypeSpec Authored with TypeSpec labels Feb 14, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed RPaaS new-api-version NotReadyForARMReview CI-RpaaSRPNotInPrivateRepo data-plane ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test labels Feb 14, 2025
@@ -2249,6 +2278,36 @@
},
"readOnly": true
},
"AutoUpgradeProfileStatus": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoUpgradeProfileStatus

update examples to show this

"type": "object",
"description": "AutoUpgradeProfileStatus is the status of an auto upgrade profile.",
"properties": {
"lastTriggeredAt": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastTriggeredAt

lastTriggeredAtInUTC ?

"readOnly": true
},
"lastTriggerError": {
"$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/ErrorDetail",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3

v5 or v6

"description": "The error details of the last trigger.",
"readOnly": true
},
"lastTriggerUpgradeVersions": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastTriggerUpgradeVersions

can these come from enums ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there will be a large amount / undefined variations of version types

@@ -2212,6 +2237,10 @@
"disabled": {
"type": "boolean",
"description": "If set to False: the auto upgrade has effect - target managed clusters will be upgraded on schedule.\nIf set to True: the auto upgrade has no effect - no upgrade will be run on the target managed clusters.\nThis is a boolean and not an enum because enabled/disabled are all available states of the auto upgrade profile.\nBy default, this is set to False."
},
"autoUpgradeProfileStatus": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoUpgradeProfileStatus

update examples to show this

@ramoka178
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Please fill in this too.

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 14, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 14, 2025

@doc("AutoUpgradeLastTriggerStatus is the status of the last AutoUpgrade trigger (attempt to automatically create and start UpdateRun when there are new released versions) of an auto upgrade profile.")
@added(Versions.v2025_03_01)
union AutoUpgradeLastTriggerStatus {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why union and not enum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMAutoSignOffPreview ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview Container Service resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants