Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the validation Check for apiId parameter in the productapis #3258

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Jun 18, 2018

Fix for issue #3260
The ApiIdParameter and ApiIdRevParameter differ in the validation check only. The parameter to be used for /products/{productId}/apis/{apiId} should be the one with relaxed validation as that is what is implemented on the service side. This is a bug in the rest specs, which came in as a customer reported issue.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2135

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1396

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2070

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2651

@solankisamir
Copy link
Member Author

@sarangan12 can you take a look at this one.

@sarangan12 sarangan12 merged commit eb1ab7c into Azure:master Jun 19, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants