Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new provider Microsoft.CostManagement and moved reports and query api documentation from Microsoft.Consumption to it #3254

Merged
merged 12 commits into from
Jun 25, 2018

Conversation

shalinved
Copy link
Contributor

@shalinved shalinved commented Jun 15, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2763

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3025

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#2121

@AutorestCI
Copy link

AutorestCI commented Jun 15, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@shalinved
Copy link
Contributor Author

@ms-premp @marbing. Please check once.

@sergey-shandar
Copy link
Contributor

@sagmor as far as I understood, these changes are API breaking changes in a stable API. All Rest API breaking changes should use new API version.

@ms-premp
Copy link
Contributor

@sergey-shandar
This is the new API-Version .. this version is not launched to public yet.. there are no SDK or CLI etc for this version yet.
So there are no breaking changes .. these all changes are new under the umbrella of a new version. This version will be declared in public namespace by end of this month.

@sagmor
Copy link

sagmor commented Jun 18, 2018

@sergey-shandar I think I'm not the right @ mention, but please let me know if I'm missing something 👍

@ms-premp
Copy link
Contributor

@sergey-shandar any progress here.

@ravbhatnagar
Copy link
Contributor

Looks good. These APIs have already been reviewed. Now as part of this PR, they are being moved under the costManagement RP. Just wanted to confirm if the intention is to add these to a GA api-version or preview?

@ms-premp
Copy link
Contributor

Yes, @ravbhatnagar .. The intention is to add them to a new GA version… which is 2018-05-31.

@sergey-shandar
Copy link
Contributor

@ms-premp we assume if it's published in this repo in the master branch under stable folder then it's public and some people may generate stable SDKs even without your knowledge. Removing/renaming operation paths from 2018-05-31 are Rest API breaking changes.

@sergey-shandar sergey-shandar added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 19, 2018
@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 19, 2018
@sergey-shandar
Copy link
Contributor

@ms-premp please, let me know when the API is publicly available so I will merge it.

@ms-premp
Copy link
Contributor

@sergey-shandar .. We are validating it right now ... will let you know, when validations are passing.

@ms-premp
Copy link
Contributor

@sergey-shandar all validations are completed. Please merge whenever you are ready.

@ms-premp
Copy link
Contributor

@sergey-shandar .. any update ?

1 similar comment
@ms-premp
Copy link
Contributor

@sergey-shandar .. any update ?

@sergey-shandar sergey-shandar merged commit 7d850c0 into Azure:master Jun 25, 2018
@sergey-shandar sergey-shandar removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 25, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 25, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants