Add mysql replica APIs into spec #3216

Suna-MS · 2018-06-12T06:06:28Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-06-12T06:07:08Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-06-12T06:07:38Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3469

AutorestCI · 2018-06-12T06:07:59Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#246

AutorestCI · 2018-06-12T06:08:16Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2978

AutorestCI · 2018-06-12T06:10:05Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2873

anuchandy · 2018-06-12T06:19:01Z

@Suna-MS are you planning to add more changes for replica? (i see api to create and list replicas). Or this is the final version?

anuchandy · 2018-06-12T16:33:22Z

@Suna-MS just to clarify, the reason I asked about completion status is to see whether it's ready for ARM review so that we can move faster.

Suna-MS · 2018-06-13T01:23:22Z

@anuchandy, this is the final version, no more APIs needed for replica. We can begin the ARM review.

QingqingYuan · 2018-06-13T18:47:46Z

...l/resource-manager/Microsoft.DBforMySQL/stable/2017-12-01/examples/ReplicasListByServer.json

+  "parameters": {
+    "serverName": "testprimary",
+    "resourceGroupName": "TestGroup",
+    "api-version": "2017-12-01-preview",


this is under stable folder. Please use the stable version as well

ravbhatnagar · 2018-06-21T07:19:58Z

specification/mysql/resource-manager/Microsoft.DBforMySQL/stable/2017-12-01/mysql.json

@@ -283,6 +286,45 @@
        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/servers/{serverName}/Replicas": {


fix casing for replicas. It should be camel case.

ravbhatnagar · 2018-06-21T07:23:39Z

specification/mysql/resource-manager/Microsoft.DBforMySQL/stable/2017-12-01/mysql.json

+          "200": {
+            "description": "OK",
+            "schema": {
+              "$ref": "#/definitions/ServerListResult"


from the API it looks like replicas is a resource type and GET on this resource type is returning a resource of another type. Is there a way to expose this via the GET on /servers and using a filter query parameter to only show the replica servers?

Replica server is also a server, not a new resource type. Replica - Primary is a relation between two servers. This API is to get all replica servers that belongs to a specified (primary) server, not all replica servers in a resource group.

AutorestCI · 2018-06-21T09:20:37Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2339

Suna-MS · 2018-06-26T01:25:23Z

There is new requirement for resource provider backend changes, need to update this spec accordingly. Please don't merge, let's wait the new public review schedule.

veronicagg · 2018-07-13T17:25:24Z

@Suna-MS any updates from your side? thx!

Suna-MS · 2018-07-17T09:06:25Z

The backend changes is rolling out to production this week, will update the spec accordingly once the word-wide deployment finished. The only change needed is update keyword from 'Primary' to 'Master'.

veronicagg · 2018-07-30T16:27:39Z

@Suna-MS have the changes been deployed?

azuresdkci · 2018-08-02T15:30:49Z

Can one of the admins verify this patch?

anuchandy · 2018-08-20T17:12:58Z

@Suna-MS just checking - is this deployed?

Suna-MS · 2018-08-21T01:51:23Z

The public review day postponed again, waiting for new schedule.

Suna-MS · 2018-09-12T08:27:14Z

@anuchandy, we can go ahead for this PR and if no other comments, can check it in.

Suna-MS · 2018-09-17T01:18:05Z

@veronicagg @anuchandy, we can continue this PR currently, can you please help to merge it?

veronicagg · 2018-09-17T16:55:35Z

@Suna-MS sure, @anuchandy who did the review can take it from here. thanks!

Suna-MS · 2018-09-29T03:59:14Z

@anuchandy, any updates?

anuchandy · 2018-10-01T02:46:28Z

Merging this PR. There is a example validation error, but doesn't look like issue with this PR. Opened an issue here Azure/oav#325 to triage.

AutorestCI · 2018-10-01T02:47:09Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

azuresdkci assigned anuchandy Jun 12, 2018

azuresdkci requested a review from anuchandy June 12, 2018 06:07

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR mysql/resource-manager] [Don't merge until 06/29/2018] Add mysql replica APIs into spec Azure/azure-sdk-for-python#2725

Closed

AutorestCI mentioned this pull request Jun 12, 2018

[AutoPR mysql/resource-manager] [Don't merge until 06/29/2018] Add mysql replica APIs into spec Azure/azure-sdk-for-go#2018

Closed

QingqingYuan reviewed Jun 13, 2018

View reviewed changes

anuchandy assigned ravbhatnagar Jun 13, 2018

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 13, 2018

anuchandy approved these changes Jun 14, 2018

View reviewed changes

QingqingYuan approved these changes Jun 19, 2018

View reviewed changes

ravbhatnagar reviewed Jun 21, 2018

View reviewed changes

AutorestCI mentioned this pull request Jun 21, 2018

[AutoPR mysql/resource-manager] [Don't merge until 06/29/2018] Add mysql replica APIs into spec Azure/azure-sdk-for-java#2128

Closed

Suna-MS changed the title ~~[Don't merge until 06/29/2018] Add mysql replica APIs into spec~~ [Don't merge, release postponed] Add mysql replica APIs into spec Jun 26, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2018

Suna-MS added 4 commits September 12, 2018 01:18

Add mysql replica APIs into spec

f1d83b0

Fix comment: update api-version in example file

a7c1b90

Fix camel case in path

886c921

Change 'primary' to 'master' in replication specs

76883a3

Suna-MS force-pushed the master branch from a298219 to 76883a3 Compare September 12, 2018 01:23

AutorestCI mentioned this pull request Sep 12, 2018

[AutoPR mysql/resource-manager] [Don't merge, release postponed] Add mysql replica APIs into spec Azure/azure-sdk-for-go#2671

Closed

Suna-MS changed the title ~~[Don't merge, release postponed] Add mysql replica APIs into spec~~ Add mysql replica APIs into spec Sep 12, 2018

anuchandy approved these changes Oct 1, 2018

View reviewed changes

anuchandy merged commit d222b8d into Azure:master Oct 1, 2018

This was referenced Oct 1, 2018

[AutoPR mysql/resource-manager] Add mysql replica APIs into spec Azure/azure-sdk-for-python#3468

Merged

[AutoPR mysql/resource-manager] Add mysql replica APIs into spec Azure/azure-sdk-for-go#2872

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mysql replica APIs into spec #3216

Add mysql replica APIs into spec #3216

Suna-MS commented Jun 12, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

anuchandy commented Jun 12, 2018

anuchandy commented Jun 12, 2018

Suna-MS commented Jun 13, 2018

QingqingYuan Jun 13, 2018

ravbhatnagar Jun 21, 2018

Suna-MS Jun 21, 2018

ravbhatnagar Jun 21, 2018

Suna-MS Jun 21, 2018

AutorestCI commented Jun 21, 2018 •

edited

Loading

Suna-MS commented Jun 26, 2018

veronicagg commented Jul 13, 2018

Suna-MS commented Jul 17, 2018

veronicagg commented Jul 30, 2018

azuresdkci commented Aug 2, 2018

anuchandy commented Aug 20, 2018

Suna-MS commented Aug 21, 2018

Suna-MS commented Sep 12, 2018

Suna-MS commented Sep 17, 2018

veronicagg commented Sep 17, 2018

Suna-MS commented Sep 29, 2018

anuchandy commented Oct 1, 2018

AutorestCI commented Oct 1, 2018 •

edited

Loading

Add mysql replica APIs into spec #3216

Add mysql replica APIs into spec #3216

Conversation

Suna-MS commented Jun 12, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Jun 12, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 12, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 12, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Jun 12, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jun 12, 2018 • edited Loading

Automation for azure-sdk-for-go

anuchandy commented Jun 12, 2018

anuchandy commented Jun 12, 2018

Suna-MS commented Jun 13, 2018

QingqingYuan Jun 13, 2018

Choose a reason for hiding this comment

ravbhatnagar Jun 21, 2018

Choose a reason for hiding this comment

Suna-MS Jun 21, 2018

Choose a reason for hiding this comment

ravbhatnagar Jun 21, 2018

Choose a reason for hiding this comment

Suna-MS Jun 21, 2018

Choose a reason for hiding this comment

AutorestCI commented Jun 21, 2018 • edited Loading

Automation for azure-sdk-for-java

Suna-MS commented Jun 26, 2018

veronicagg commented Jul 13, 2018

Suna-MS commented Jul 17, 2018

veronicagg commented Jul 30, 2018

azuresdkci commented Aug 2, 2018

anuchandy commented Aug 20, 2018

Suna-MS commented Aug 21, 2018

Suna-MS commented Sep 12, 2018

Suna-MS commented Sep 17, 2018

veronicagg commented Sep 17, 2018

Suna-MS commented Sep 29, 2018

anuchandy commented Oct 1, 2018

AutorestCI commented Oct 1, 2018 • edited Loading

Automation for azure-sdk-for-js

Suna-MS commented Jun 12, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 12, 2018 •

edited

Loading

AutorestCI commented Jun 21, 2018 •

edited

Loading

AutorestCI commented Oct 1, 2018 •

edited

Loading