Add new backup discovery API. Fix error codes for source control API,… #3195
Conversation
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
|
@naveedaz please fix the issues reported by CI https://travis-ci.org/Azure/azure-rest-api-specs/jobs/389472254 |
|
@anuchandy Fixed. |
| }, | ||
| "description": { | ||
| "description": "** New Implementation Only **\nDescription.", | ||
| "type": "string" |
There was a problem hiding this comment.
can you provide description for all these new properties?
| "deletedSiteId": { | ||
| "format": "int32", | ||
| "description": "Numeric id for the deleted site", | ||
| "type": "integer" |
There was a problem hiding this comment.
is this property deletedSiteId eligible to be marked as readonly?
| "type": "string" | ||
| }, | ||
| "blobDuration": { | ||
| "type": "string" |
There was a problem hiding this comment.
Is this a numeric value? if so should we use one of the numeric types?
| "x-ms-mutability": [ | ||
| "create" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Removing property is breaking change, this should be done as part of new api-version
There was a problem hiding this comment.
@anuchandy Api version 2018-02-01 is not part of the default package tag so no clients are generated from it yet. 2018-02-01 is a new version. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/web/resource-manager/readme.md#basic-information
| @@ -1989,7 +2073,7 @@ | |||
| "description": "Linux App Framework and version", | |||
| "type": "string" | |||
| }, | |||
| "xenonFxVersion": { | |||
| "windowsFxVersion": { | |||
There was a problem hiding this comment.
This is a breaking change (renaming of properties from the payload), should be done as part of new api version
| }, | ||
| "isXenon": { | ||
| "description": "<code>true</code> if App Service plan is running as a windows container", | ||
| "type": "boolean" |
There was a problem hiding this comment.
above we are renaming xenonFxVersion to windowsFxVersion, which means having isXenon property instead of isWindows is inconsistent right?
There was a problem hiding this comment.
This distinguishes between windows and xenon windows and is therefore expected.
| "schema": { | ||
| "$ref": "#/definitions/SwiftVirtualNetwork" | ||
| } | ||
| }, |
There was a problem hiding this comment.
is this a long running operation?, if yes model it accordingly
| "responses": { | ||
| "200": { | ||
| "description": "Succesfully deleted virtual network." | ||
| }, |
| "schema": { | ||
| "$ref": "#/definitions/SwiftVirtualNetwork" | ||
| } | ||
| }, |
| "schema": { | ||
| "$ref": "#/definitions/RestoreRequest" | ||
| } | ||
| }, |
There was a problem hiding this comment.
is restore a long running operation?
|
@naveedaz thanks for confirming that there is no SDK released for the api-version 2018-02-01. There are other feedbacks (not related to breaking changes), can you address them? |
Automation for azure-sdk-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
@anuchandy Please take a look. |
anuchandy
added
the
WaitForARMFeedback
|
Looking at this PR #2802, Gaurav mentioned that this api-version (2018-02-01) is already deployed. Though this api-version is not part of default package (hence no SDK generated and no breaking change in SDK), in the api-level they are still breaking. Hence i'm requesting ARM to take a look and signoff. cc @ravbhatnagar |
|
@naveedaz - Removing snapshotInfo from sites is technically a breaking change? Is it being used through this api-version? Will there be a customer impact of removing it if its being used via another client (portal or custom)? |
|
@Nking92 Can you elaborate on how this property was never used. |
|
Regarding snapshotInfo - this property was never supported and should have been hidden from Swagger, but I forgot to mark it as "ignored". It was intended for an experimental feature for creating a new app from a snapshot, but we don't support that feature now. It would be best to get rid of it. I doubt any customers have a dependency on it. We created an alternative set of APIs for restoring from snapshots that customers should use instead. |
|
ping @ravbhatnagar |
|
based on ACK from RP that this property is not supported, good to remove. |
ravbhatnagar
added
ARMSignedOff
|
@anuchandy @veronicagg Can you please merge. |
veronicagg
dismissed
anuchandy’s stale review
Anu is OOF, so I'm merging for him
|
Thanks @veronicagg |
|
#3195 (comment) was never addressed. Java SDK hurts now 😭 |
… Move DeletedSite to common definition
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger